Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2219853002: Cleanup: Declaration doesn't need to know Zone. (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup: Declaration doesn't need to know Zone. It wasn't using it for anything. R=verwaest@chromium.org BUG= Committed: https://crrev.com/74feddd5e1daf9028b3651fe40d0a51014cfbd8d Cr-Commit-Position: refs/heads/master@{#38416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/ast/ast.h View 5 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
marja
ptal
4 years, 4 months ago (2016-08-05 12:02:23 UTC) #3
adamk
lgtm
4 years, 4 months ago (2016-08-05 21:48:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219853002/1
4 years, 4 months ago (2016-08-08 07:49:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 08:14:43 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 08:18:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74feddd5e1daf9028b3651fe40d0a51014cfbd8d
Cr-Commit-Position: refs/heads/master@{#38416}

Powered by Google App Engine
This is Rietveld 408576698