Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2219823002: Move content offset to ViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pass right bounds to snapshot api Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_android.h" 5 #include "content/browser/renderer_host/render_widget_host_view_android.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
688 while (locks_on_frame_count_ > 0) { 688 while (locks_on_frame_count_ > 0) {
689 UnlockCompositingSurface(); 689 UnlockCompositingSurface();
690 } 690 }
691 RunAckCallbacks(); 691 RunAckCallbacks();
692 } 692 }
693 693
694 gfx::Rect RenderWidgetHostViewAndroid::GetViewBounds() const { 694 gfx::Rect RenderWidgetHostViewAndroid::GetViewBounds() const {
695 if (!content_view_core_) 695 if (!content_view_core_)
696 return default_bounds_; 696 return default_bounds_;
697 697
698 if (base::CommandLine::ForCurrentProcess()->HasSwitch( 698 bool osk_overscroll = base::CommandLine::ForCurrentProcess()->HasSwitch(
699 switches::kEnableOSKOverscroll)) 699 switches::kEnableOSKOverscroll);
700 return gfx::Rect(content_view_core_->GetViewSizeWithOSKHidden()); 700 gfx::Rect bounds = gfx::Rect(osk_overscroll ?
701 701 content_view_core_->GetViewSizeWithOSKHidden() :
702 return gfx::Rect(content_view_core_->GetViewSize()); 702 content_view_core_->GetViewSize());
703 bounds.Offset(0, view_.content_offset().y());
704 return bounds;
703 } 705 }
704 706
705 gfx::Size RenderWidgetHostViewAndroid::GetVisibleViewportSize() const { 707 gfx::Size RenderWidgetHostViewAndroid::GetVisibleViewportSize() const {
706 if (!content_view_core_) 708 if (!content_view_core_)
707 return default_bounds_.size(); 709 return default_bounds_.size();
708 710
709 return content_view_core_->GetViewSize(); 711 return content_view_core_->GetViewSize();
710 } 712 }
711 713
712 gfx::Size RenderWidgetHostViewAndroid::GetPhysicalBackingSize() const { 714 gfx::Size RenderWidgetHostViewAndroid::GetPhysicalBackingSize() const {
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1351 viewport_size.Scale(frame_metadata.page_scale_factor); 1353 viewport_size.Scale(frame_metadata.page_scale_factor);
1352 gfx::RectF viewport_rect(0.0f, frame_metadata.top_controls_height * 1354 gfx::RectF viewport_rect(0.0f, frame_metadata.top_controls_height *
1353 frame_metadata.top_controls_shown_ratio, 1355 frame_metadata.top_controls_shown_ratio,
1354 viewport_size.width(), viewport_size.height()); 1356 viewport_size.width(), viewport_size.height());
1355 selection_controller_->OnViewportChanged(viewport_rect); 1357 selection_controller_->OnViewportChanged(viewport_rect);
1356 } 1358 }
1357 1359
1358 UpdateBackgroundColor(is_transparent ? SK_ColorTRANSPARENT 1360 UpdateBackgroundColor(is_transparent ? SK_ColorTRANSPARENT
1359 : frame_metadata.root_background_color); 1361 : frame_metadata.root_background_color);
1360 1362
1363 view_.set_content_offset(gfx::Vector2dF(0.0f,
1364 frame_metadata.top_controls_height *
1365 frame_metadata.top_controls_shown_ratio));
1366
1361 // All offsets and sizes are in CSS pixels. 1367 // All offsets and sizes are in CSS pixels.
1362 content_view_core_->UpdateFrameInfo( 1368 content_view_core_->UpdateFrameInfo(
1363 frame_metadata.root_scroll_offset, 1369 frame_metadata.root_scroll_offset,
1364 frame_metadata.page_scale_factor, 1370 frame_metadata.page_scale_factor,
1365 gfx::Vector2dF(frame_metadata.min_page_scale_factor, 1371 gfx::Vector2dF(frame_metadata.min_page_scale_factor,
1366 frame_metadata.max_page_scale_factor), 1372 frame_metadata.max_page_scale_factor),
1367 frame_metadata.root_layer_size, 1373 frame_metadata.root_layer_size,
1368 frame_metadata.scrollable_viewport_size, 1374 frame_metadata.scrollable_viewport_size,
1369 frame_metadata.top_controls_height, 1375 frame_metadata.top_controls_height,
1370 frame_metadata.top_controls_shown_ratio, 1376 frame_metadata.top_controls_shown_ratio,
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
2039 if (!compositor) 2045 if (!compositor)
2040 return; 2046 return;
2041 2047
2042 overscroll_controller_ = base::MakeUnique<OverscrollControllerAndroid>( 2048 overscroll_controller_ = base::MakeUnique<OverscrollControllerAndroid>(
2043 overscroll_refresh_handler, compositor, 2049 overscroll_refresh_handler, compositor,
2044 ui::GetScaleFactorForNativeView(GetNativeView())); 2050 ui::GetScaleFactorForNativeView(GetNativeView()));
2045 is_showing_overscroll_glow_ = true; 2051 is_showing_overscroll_glow_ = true;
2046 } 2052 }
2047 2053
2048 } // namespace content 2054 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698