Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2219803002: [keys] Throw a range error if the number of keys overflow FixedArray::kMaxLength (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Franzi
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] Throw a range error if the number of keys overflow FixedArray::kMaxLength BUG=chromium:634776 Committed: https://crrev.com/172bfb58345f9eefd804714f787cf2c4981b2eab Cr-Commit-Position: refs/heads/master@{#38382}

Patch Set 1 #

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M src/elements.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/elements.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M src/keys.cc View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-05 09:34:24 UTC) #2
Franzi
lgtm
4 years, 4 months ago (2016-08-05 11:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219803002/20001
4 years, 4 months ago (2016-08-05 12:01:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 12:52:07 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:52:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/172bfb58345f9eefd804714f787cf2c4981b2eab
Cr-Commit-Position: refs/heads/master@{#38382}

Powered by Google App Engine
This is Rietveld 408576698