chrome/browser/resources/md_history/synced_device_card.js - Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/synced_device_card.js

Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rewrite patch to listen to click event, add regression test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/constants.js ('K') | « chrome/browser/resources/md_history/synced_device_card.html ('k') | chrome/test/data/webui/md_history/history_synced_tabs_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/synced_device_card.js

diff --git a/chrome/browser/resources/md_history/synced_device_card.js b/chrome/browser/resources/md_history/synced_device_card.js

index 4e807781cab51ef016ee62d0b10d4a818dae5302..72076e8fa560b4e47b283a2a06bd68a544fb23c2 100644

--- a/chrome/browser/resources/md_history/synced_device_card.js

+++ b/chrome/browser/resources/md_history/synced_device_card.js

@@ -48,14 +48,15 @@ Polymer({

/**

- * @param {TapEvent} e

+ * Open a single synced tab. Listens to 'click' rather than 'tap'

+ * to determine what modifier keys were pressed.

+ * @param {RepeatClickEvent} e

* @private

openTab_: function(e) {

var tab = /** @type {ForeignSessionTab} */(e.model.tab);

- var srcEvent = /** @type {Event} */(e.detail.sourceEvent);

md_history.BrowserService.getInstance().openForeignSessionTab(

- this.sessionTag, tab.windowId, tab.sessionId, srcEvent);

+ this.sessionTag, tab.windowId, tab.sessionId, e);

e.preventDefault();