chrome/browser/resources/md_history/browser_service.js - Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/browser_service.js

Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rewrite patch to listen to click event, add regression test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/md_history/browser_service.js

diff --git a/chrome/browser/resources/md_history/browser_service.js b/chrome/browser/resources/md_history/browser_service.js

index d4c4579006b49a7d27ac8155f9397ee232267442..c7cf5302b45d6a283672201d42f4fed70966c225 100644

--- a/chrome/browser/resources/md_history/browser_service.js

+++ b/chrome/browser/resources/md_history/browser_service.js

@@ -60,7 +60,7 @@ cr.define('md_history', function() {

* @param {string} sessionTag

* @param {number} windowId

* @param {number} tabId

- * @param {Event} e

+ * @param {MouseEvent} e

openForeignSessionTab: function(sessionTag, windowId, tabId, e) {

chrome.send('openForeignSession', [

« no previous file with comments | « no previous file | chrome/browser/resources/md_history/constants.js » ('j') | chrome/browser/resources/md_history/constants.js » ('J')