Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: chrome/browser/resources/md_history/synced_device_card.html

Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite patch to listen to click event, add regression test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
7 <link rel="import" href="chrome://resources/html/icon.html"> 7 <link rel="import" href="chrome://resources/html/icon.html">
8 <link rel="import" href="chrome://history/browser_service.html"> 8 <link rel="import" href="chrome://history/browser_service.html">
9 <link rel="import" href="chrome://history/constants.html"> 9 <link rel="import" href="chrome://history/constants.html">
10 <link rel="import" href="chrome://history/searched_label.html"> 10 <link rel="import" href="chrome://history/searched_label.html">
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 </iron-icon> 83 </iron-icon>
84 </button> 84 </button>
85 </div> 85 </div>
86 86
87 <iron-collapse opened="{{cardOpen_}}" id="collapse"> 87 <iron-collapse opened="{{cardOpen_}}" id="collapse">
88 <div id="tab-item-list"> 88 <div id="tab-item-list">
89 <template is="dom-repeat" items="[[tabs]]" as="tab" id="tab-list"> 89 <template is="dom-repeat" items="[[tabs]]" as="tab" id="tab-list">
90 <div id="item-container"> 90 <div id="item-container">
91 <div id="icon" class="website-icon"></div> 91 <div id="icon" class="website-icon"></div>
92 <a href="[[tab.url]]" class="website-title" title="[[tab.title]]" 92 <a href="[[tab.url]]" class="website-title" title="[[tab.title]]"
93 on-tap="openTab_"> 93 on-click="openTab_">
94 <history-searched-label title="[[tab.title]]" 94 <history-searched-label title="[[tab.title]]"
95 search-term="[[searchTerm]]"></history-searched-label> 95 search-term="[[searchTerm]]"></history-searched-label>
96 </a> 96 </a>
97 </div> 97 </div>
98 <div id="window-separator" 98 <div id="window-separator"
99 hidden$="[[!isWindowSeparatorIndex_(index, separatorIndexes)]]"> 99 hidden$="[[!isWindowSeparatorIndex_(index, separatorIndexes)]]">
100 </div> 100 </div>
101 </template> 101 </template>
102 <div class="item-container"> 102 <div class="item-container">
103 <p on-tap="openAllTabs_" id="open-tabs">$i18n{openAll}</p> 103 <p on-tap="openAllTabs_" id="open-tabs">$i18n{openAll}</p>
104 </div> 104 </div>
105 </div> 105 </div>
106 </iron-collapse> 106 </iron-collapse>
107 </div> 107 </div>
108 </template> 108 </template>
109 <script src="chrome://history/synced_device_card.js"></script> 109 <script src="chrome://history/synced_device_card.js"></script>
110 </dom-module> 110 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698