Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/md_history/constants.js

Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite patch to listen to click event, add regression test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/md_history/browser_service.js ('k') | chrome/browser/resources/md_history/synced_device_card.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Globals: 5 // Globals:
6 /** @const */ var RESULTS_PER_PAGE = 150; 6 /** @const */ var RESULTS_PER_PAGE = 150;
7 7
8 /** 8 /**
9 * Amount of time between pageviews that we consider a 'break' in browsing, 9 * Amount of time between pageviews that we consider a 'break' in browsing,
10 * measured in milliseconds. 10 * measured in milliseconds.
(...skipping 29 matching lines...) Expand all
40 var QueryState; 40 var QueryState;
41 41
42 /** 42 /**
43 * @typedef {{info: ?HistoryQuery, 43 * @typedef {{info: ?HistoryQuery,
44 * results: ?Array<!HistoryEntry>, 44 * results: ?Array<!HistoryEntry>,
45 * sessionList: ?Array<!ForeignSession>}} 45 * sessionList: ?Array<!ForeignSession>}}
46 */ 46 */
47 var QueryResult; 47 var QueryResult;
48 48
49 /** @constructor 49 /** @constructor
50 * @extends {CustomEvent} */ 50 * @extends {MouseEvent} */
51 var TapEvent = function() { 51 var RepeatClickEvent = function() {
calamity 2016/08/09 03:40:40 DomRepeatClickEvent perhaps? This almost sounds li
tsergeant 2016/08/09 03:57:02 Good point, done.
52 this.model = null; 52 this.model = null;
53 }; 53 };
OLDNEW
« no previous file with comments | « chrome/browser/resources/md_history/browser_service.js ('k') | chrome/browser/resources/md_history/synced_device_card.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698