Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/resources/md_history/browser_service.js

Issue 2219753002: MD History: Fix crash when opening Synced Tab links with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rewrite patch to listen to click event, add regression test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Defines a singleton object, md_history.BrowserService, which 6 * @fileoverview Defines a singleton object, md_history.BrowserService, which
7 * provides access to chrome.send APIs. 7 * provides access to chrome.send APIs.
8 */ 8 */
9 9
10 cr.define('md_history', function() { 10 cr.define('md_history', function() {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 * @param {string} sessionTag 53 * @param {string} sessionTag
54 */ 54 */
55 openForeignSessionAllTabs: function(sessionTag) { 55 openForeignSessionAllTabs: function(sessionTag) {
56 chrome.send('openForeignSession', [sessionTag]); 56 chrome.send('openForeignSession', [sessionTag]);
57 }, 57 },
58 58
59 /** 59 /**
60 * @param {string} sessionTag 60 * @param {string} sessionTag
61 * @param {number} windowId 61 * @param {number} windowId
62 * @param {number} tabId 62 * @param {number} tabId
63 * @param {Event} e 63 * @param {MouseEvent} e
64 */ 64 */
65 openForeignSessionTab: function(sessionTag, windowId, tabId, e) { 65 openForeignSessionTab: function(sessionTag, windowId, tabId, e) {
66 chrome.send('openForeignSession', [ 66 chrome.send('openForeignSession', [
67 sessionTag, String(windowId), String(tabId), e.button || 0, e.altKey, 67 sessionTag, String(windowId), String(tabId), e.button || 0, e.altKey,
68 e.ctrlKey, e.metaKey, e.shiftKey 68 e.ctrlKey, e.metaKey, e.shiftKey
69 ]); 69 ]);
70 }, 70 },
71 71
72 openClearBrowsingData: function() { 72 openClearBrowsingData: function() {
73 chrome.send('clearBrowsingData'); 73 chrome.send('clearBrowsingData');
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 md_history.BrowserService.getInstance().resolveDelete_(true); 105 md_history.BrowserService.getInstance().resolveDelete_(true);
106 } 106 }
107 107
108 /** 108 /**
109 * Called by the history backend when the deletion failed. 109 * Called by the history backend when the deletion failed.
110 */ 110 */
111 function deleteFailed() { 111 function deleteFailed() {
112 md_history.BrowserService.getInstance().resolveDelete_(false); 112 md_history.BrowserService.getInstance().resolveDelete_(false);
113 } 113 }
114 114
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/constants.js » ('j') | chrome/browser/resources/md_history/constants.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698