MD History: Fix crash when opening Synced Tab links with touch

MD History: Fix crash when opening Synced Tab links with touch

The event handler for synced tab clicks needs to know what modifier keys
were pressed during the click, but Polymer tap events do not include this
information from touch events. Instead, this changes the handler to
listen to a plain 'click' event, which will always include this
information.

BUG=634236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e
Cr-Commit-Position: refs/heads/master@{#410597}

[tsergeant, 2016-08-05 07:10:36]

Description was changed from

==========
MD History: Fix crash when opening Synced Tab links with touch

This fixes an issue where the event handler for synced tab clicks
assumed that it was not fired from a touchscreen device.

BUG=634236
==========

to

==========
MD History: Fix crash when opening Synced Tab links with touch

This fixes an issue where the event handler for synced tab clicks
assumed that it was not fired from a touchscreen device.

BUG=634236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-05 07:10:48]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 07:10:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 08:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 08:23:56]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tsergeant, 2016-08-07 23:58:47]

Description was changed from

==========
MD History: Fix crash when opening Synced Tab links with touch

This fixes an issue where the event handler for synced tab clicks
assumed that it was not fired from a touchscreen device.

BUG=634236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Fix crash when opening Synced Tab links with touch

The event handler for synced tab clicks needs to know what modifier keys
were pressed during the click, but Polymer tap events do not include this
information from touch events. Instead, this changes the handler to
listen to a plain 'click' event, which will always include this
information.

BUG=634236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-07 23:59:37]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 23:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-08-08 00:02:48]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2016-08-08 00:02:54]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 00:03:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-08-08 00:03:17]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2016-08-08 00:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 00:59:34]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-08-09 03:40:41]

lgtm

https://codereview.chromium.org/2219753002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/constants.js (right):

https://codereview.chromium.org/2219753002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/constants.js:51: var RepeatClickEvent =
function() {
DomRepeatClickEvent perhaps? This almost sounds like a repeated click event as
is.

[tsergeant, 2016-08-09 03:57:02]

https://codereview.chromium.org/2219753002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/md_history/constants.js (right):

https://codereview.chromium.org/2219753002/diff/40001/chrome/browser/resource...
chrome/browser/resources/md_history/constants.js:51: var RepeatClickEvent =
function() {
On 2016/08/09 03:40:40, calamity wrote:
> DomRepeatClickEvent perhaps? This almost sounds like a repeated click event as
> is.

Good point, done.

[tsergeant, 2016-08-09 03:57:07]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-08-09 03:57:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2219753002/#ps60001
(title: "Rename closure type")

[commit-bot: I haz the power, 2016-08-09 03:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 05:34:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 05:34:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tsergeant, 2016-08-09 05:39:38]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-08-09 05:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 06:27:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-09 06:29:36]

Description was changed from

==========
MD History: Fix crash when opening Synced Tab links with touch

The event handler for synced tab clicks needs to know what modifier keys
were pressed during the click, but Polymer tap events do not include this
information from touch events. Instead, this changes the handler to
listen to a plain 'click' event, which will always include this
information.

BUG=634236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Fix crash when opening Synced Tab links with touch

The event handler for synced tab clicks needs to know what modifier keys
were pressed during the click, but Polymer tap events do not include this
information from touch events. Instead, this changes the handler to
listen to a plain 'click' event, which will always include this
information.

BUG=634236
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e
Cr-Commit-Position: refs/heads/master@{#410597}
==========

[commit-bot: I haz the power, 2016-08-09 06:29:37]

Patchset 3 (id:??) landed as
https://crrev.com/ec398f6d0d29522ae9b7cd07ac611e8e82e05e8e
Cr-Commit-Position: refs/heads/master@{#410597}