Format GN files in-place by default.

Format GN files in-place by default.

Almost all manual uses of "gn format" are to update files in-place. Make
this mode the default rather than requiring --in-place to be passed.

With this change, you can update a file in-place or use pipes, but the previous
mode to take input from a file and output to stdout is lost. This seems to be
not a strong use-case, and one can always pipe a file to stdin to work around
the limitation.

Suppresses outputting formated data when --dump-tree is specified.

Committed: https://crrev.com/16ad3fe769c7215728e6c7661674d871d5fe3052
Cr-Commit-Position: refs/heads/master@{#410137}

[brettw, 2016-08-05 17:22:18]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2016-08-05 17:22:23]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:22:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-08-05 17:31:48]

https://codereview.chromium.org/2219703003/diff/1/tools/gn/command_format.cc
File tools/gn/command_format.cc (right):

https://codereview.chromium.org/2219703003/diff/1/tools/gn/command_format.cc#...
tools/gn/command_format.cc:33: "gn format [--dump-tree] [--stdin | <build_file>
]\n"
no space between file> and ]. Or probably better to remove the [], since they're
not optional.

https://codereview.chromium.org/2219703003/diff/1/tools/gn/command_format.cc#...
tools/gn/command_format.cc:1042: if (dump_tree) {
It's a bit weird that dump_tree means that it doesn't actually format the file.
But doesn't matter either way, just update the docstring to match the new
behaviour if you prefer it this way.

https://codereview.chromium.org/2219703003/diff/1/tools/gn/command_format.cc#...
tools/gn/command_format.cc:1044: } else if (from_stdin) {
I don't think this is ever reached. If it's from_stdin, the
FormatStringToString() above is used.

[brettw, 2016-08-05 17:47:11]

comments

[brettw, 2016-08-05 17:47:12]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:47:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-08-05 17:48:07]

PTAL.

I changed the docstring to use () since you have to do one or the other (I think
this is typical syntax).

[scottmg, 2016-08-05 17:50:50]

lgtm. (I would have used {}, but () seems clear enough.)

[commit-bot: I haz the power, 2016-08-05 18:33:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:33:27]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-08-05 19:14:49]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:15:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 19:19:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-05 19:21:11]

Description was changed from

==========
Format GN files in-place by default.

Almost all manual uses of "gn format" are to update files in-place. Make
this mode the default rather than requiring --in-place to be passed.

With this change, you can update a file in-place or use pipes, but the previous
mode to take input from a file and output to stdout is lost. This seems to be
not a strong use-case, and one can always pipe a file to stdin to work around
the limitation.

Suppresses outputting formated data when --dump-tree is specified.
==========

to

==========
Format GN files in-place by default.

Almost all manual uses of "gn format" are to update files in-place. Make
this mode the default rather than requiring --in-place to be passed.

With this change, you can update a file in-place or use pipes, but the previous
mode to take input from a file and output to stdout is lost. This seems to be
not a strong use-case, and one can always pipe a file to stdin to work around
the limitation.

Suppresses outputting formated data when --dump-tree is specified.

Committed: https://crrev.com/16ad3fe769c7215728e6c7661674d871d5fe3052
Cr-Commit-Position: refs/heads/master@{#410137}
==========

[commit-bot: I haz the power, 2016-08-05 19:21:12]

Patchset 2 (id:??) landed as
https://crrev.com/16ad3fe769c7215728e6c7661674d871d5fe3052
Cr-Commit-Position: refs/heads/master@{#410137}

[Dirk Pranke, 2016-08-08 21:08:33]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-08 21:08:34]

lgtm