Chromium Code Reviews
DescriptionRevert of Add joinable option to SimpleThread::Options as was just done for Thread.
(patchset #2 id:20001 of https://codereview.chromium.org/2204333003/ )
Reason for revert:
Reverting this since it is breaking the iOS base_unittests.
gba@ is working on a fix in https://codereview.chromium.org/2218983003/
Original issue's description:
> Add joinable option to SimpleThread::Options as was just done for Thread::Options.
>
> SimpleThread will be more suitable than Thread for
> https://codereview.chromium.org/2197753002/ per it not needing a MessageLoop.
>
> Also, cleanup the SimpleThread::Options API, making it more like Thread::Options.
>
> BUG=629716
> TBR=avi@chromium.org
>
> Committed: https://crrev.com/8b35b0572443f4a84377a1fbd199a1edabe3d7d6
> Cr-Commit-Position: refs/heads/master@{#409830}
TBR=thestig@chromium.org,avi@chromium.org,gab@chromium.org
BUG=629716
Committed: https://crrev.com/a9094bdb2cda679e8bf3a5b43b27c12efa975d3c
Cr-Commit-Position: refs/heads/master@{#410169}
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||