Disallow uninitialized non-nullable variables

Disallow uninitialized non-nullable variables

Declaring a non-nullable variable without initializing it is a static
error. If a constant is declared instead (either run-time or
compile-time) the error handling logic is the same as before.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/f5f4bb4ebd798cbd01b6c3d4763bda9d8171031b

[stanm, 2016-08-05 17:15:21]

stanm@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[Jennifer Messerly, 2016-08-05 17:39:31]

overall lgtm, just a couple of comments/questions

https://codereview.chromium.org/2219653005/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2219653005/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/checker.dart:766: *
missing doc comment here?

https://codereview.chromium.org/2219653005/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/checker.dart:768: void
_checkForNonNullNotInitialized(VariableDeclarationList list) {
you might be able to put this logic in visitVariableDeclaration? That way we
wouldn't need to walk over the list twice. Assuming those other nodes do in fact
visit the variable declaration nodes.

[stanm, 2016-08-05 18:06:52]

https://codereview.chromium.org/2219653005/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/2219653005/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong/checker.dart:768: void
_checkForNonNullNotInitialized(VariableDeclarationList list) {
On 2016/08/05 17:39:31, John Messerly wrote:
> you might be able to put this logic in visitVariableDeclaration? That way we
> wouldn't need to walk over the list twice. Assuming those other nodes do in
fact
> visit the variable declaration nodes.

Awesome! Thanks!

[stanm, 2016-08-05 18:07:55]

Description was changed from

==========
Disallow uninitialized non-nullable variables

Declaring a non-nullable variable without initializing it is a static
error. If a constant is declared instead (either run-time or
compile-time) the error handling logic is the same as before.

BUG=
==========

to

==========
Disallow uninitialized non-nullable variables

Declaring a non-nullable variable without initializing it is a static
error. If a constant is declared instead (either run-time or
compile-time) the error handling logic is the same as before.

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f5f4bb4ebd798cbd01b6c3d4763bda9d8171031b
==========

[stanm, 2016-08-05 18:07:56]

Committed patchset #3 (id:40001) manually as
f5f4bb4ebd798cbd01b6c3d4763bda9d8171031b (presubmit successful).