Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: sync/notifier/invalidation_state_tracker.h

Issue 221963003: Reduce dependency of TiclInvalidationService on Profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made InvalidationStateTracker not vend WeakPtrs. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/invalidation_state_tracker.h
diff --git a/sync/notifier/invalidation_state_tracker.h b/sync/notifier/invalidation_state_tracker.h
index 81a07eae5c51555792a4b42c7c9d04272cdb3aff..36943d55b0c35029f418f192964f9d7d2d84dbe8 100644
--- a/sync/notifier/invalidation_state_tracker.h
+++ b/sync/notifier/invalidation_state_tracker.h
@@ -33,11 +33,13 @@ namespace syncer {
class InvalidationStateTracker {
public:
InvalidationStateTracker() {}
+ virtual ~InvalidationStateTracker() {}
// The per-client unique ID used to register the invalidation client with the
// server. This is used to squelch invalidation notifications that originate
- // from changes made by this client.
- virtual void SetInvalidatorClientId(const std::string& data) = 0;
+ // from changes made by this client. Setting the client ID clears all other
+ // state.
+ virtual void ClearAndSetNewClientId(const std::string& data) = 0;
virtual std::string GetInvalidatorClientId() const = 0;
// Used by invalidation::InvalidationClient for persistence. |data| is an
@@ -55,9 +57,6 @@ class InvalidationStateTracker {
// Erases invalidation versions, client ID, and state stored on disk.
virtual void Clear() = 0;
-
- protected:
- virtual ~InvalidationStateTracker() {}
};
} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698