chrome/browser/invalidation/invalidator_storage_unittest.cc - Issue 221963003: Reduce dependency of TiclInvalidationService on Profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/invalidation/invalidator_storage_unittest.cc

Issue 221963003: Reduce dependency of TiclInvalidationService on Profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Made InvalidationStateTracker not vend WeakPtrs. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/invalidation/invalidator_storage_unittest.cc

diff --git a/chrome/browser/invalidation/invalidator_storage_unittest.cc b/chrome/browser/invalidation/invalidator_storage_unittest.cc

index b09d8d5c3a728d5a9c86a5f5857aa9efeab94857..b58799738bbee34abebf35c881abf15985e03d52 100644

--- a/chrome/browser/invalidation/invalidator_storage_unittest.cc

+++ b/chrome/browser/invalidation/invalidator_storage_unittest.cc

@@ -32,7 +32,7 @@ TEST_F(InvalidatorStorageTest, Clear) {

EXPECT_TRUE(storage.GetBootstrapData().empty());

EXPECT_TRUE(storage.GetInvalidatorClientId().empty());

- storage.SetInvalidatorClientId("fake_id");

+ storage.ClearAndSetNewClientId("fake_id");

EXPECT_EQ("fake_id", storage.GetInvalidatorClientId());

storage.SetBootstrapData("test");

@@ -48,7 +48,7 @@ TEST_F(InvalidatorStorageTest, SetGetNotifierClientId) {

InvalidatorStorage storage(&pref_service_);

const std::string client_id("fK6eDzAIuKqx9A4+93bljg==");

- storage.SetInvalidatorClientId(client_id);

+ storage.ClearAndSetNewClientId(client_id);

EXPECT_EQ(client_id, storage.GetInvalidatorClientId());

}