Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: sync/notifier/invalidation_notifier_unittest.cc

Issue 221963003: Reduce dependency of TiclInvalidationService on Profile (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made InvalidationStateTracker not vend WeakPtrs. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/invalidation_notifier.h" 5 #include "sync/notifier/invalidation_notifier.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/memory/weak_ptr.h"
8 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
9 #include "jingle/notifier/base/fake_base_task.h" 10 #include "jingle/notifier/base/fake_base_task.h"
10 #include "jingle/notifier/base/notifier_options.h" 11 #include "jingle/notifier/base/notifier_options.h"
11 #include "jingle/notifier/listener/fake_push_client.h" 12 #include "jingle/notifier/listener/fake_push_client.h"
12 #include "net/url_request/url_request_test_util.h" 13 #include "net/url_request/url_request_test_util.h"
13 #include "sync/internal_api/public/base/model_type.h" 14 #include "sync/internal_api/public/base/model_type.h"
14 #include "sync/internal_api/public/util/weak_handle.h"
15 #include "sync/notifier/fake_invalidation_handler.h" 15 #include "sync/notifier/fake_invalidation_handler.h"
16 #include "sync/notifier/fake_invalidation_state_tracker.h" 16 #include "sync/notifier/fake_invalidation_state_tracker.h"
17 #include "sync/notifier/invalidation_state_tracker.h" 17 #include "sync/notifier/invalidation_state_tracker.h"
18 #include "sync/notifier/invalidator_test_template.h" 18 #include "sync/notifier/invalidator_test_template.h"
19 #include "sync/notifier/push_client_channel.h" 19 #include "sync/notifier/push_client_channel.h"
20 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
21 21
22 namespace syncer { 22 namespace syncer {
23 23
24 namespace { 24 namespace {
25 25
26 class InvalidationNotifierTestDelegate { 26 class InvalidationNotifierTestDelegate {
27 public: 27 public:
28 InvalidationNotifierTestDelegate() {} 28 InvalidationNotifierTestDelegate() {}
29 29
30 ~InvalidationNotifierTestDelegate() { 30 ~InvalidationNotifierTestDelegate() {
31 DestroyInvalidator(); 31 DestroyInvalidator();
32 } 32 }
33 33
34 void CreateInvalidator( 34 void CreateInvalidator(const std::string& invalidator_client_id,
35 const std::string& invalidator_client_id, 35 const std::string& initial_state,
36 const std::string& initial_state, 36 InvalidationStateTracker* invalidation_state_tracker) {
37 const base::WeakPtr<InvalidationStateTracker>& 37 DCHECK(!invalidator_);
38 invalidation_state_tracker) { 38 invalidation_state_tracker_weak_ptr_factory_.reset(
39 DCHECK(!invalidator_.get()); 39 new base::WeakPtrFactory<InvalidationStateTracker>(
40 invalidation_state_tracker));
40 scoped_ptr<notifier::PushClient> push_client( 41 scoped_ptr<notifier::PushClient> push_client(
41 new notifier::FakePushClient()); 42 new notifier::FakePushClient());
42 scoped_ptr<SyncNetworkChannel> network_channel( 43 scoped_ptr<SyncNetworkChannel> network_channel(
43 new PushClientChannel(push_client.Pass())); 44 new PushClientChannel(push_client.Pass()));
44 invalidator_.reset( 45 invalidator_.reset(new InvalidationNotifier(
45 new InvalidationNotifier( 46 network_channel.Pass(),
46 network_channel.Pass(), 47 invalidator_client_id,
47 invalidator_client_id, 48 UnackedInvalidationsMap(),
48 UnackedInvalidationsMap(), 49 initial_state,
49 initial_state, 50 MakeWeakHandle(
50 MakeWeakHandle(invalidation_state_tracker), 51 invalidation_state_tracker_weak_ptr_factory_->GetWeakPtr()),
51 "fake_client_info")); 52 "fake_client_info"));
52 } 53 }
53 54
54 Invalidator* GetInvalidator() { 55 Invalidator* GetInvalidator() {
55 return invalidator_.get(); 56 return invalidator_.get();
56 } 57 }
57 58
58 void DestroyInvalidator() { 59 void DestroyInvalidator() {
59 // Stopping the invalidation notifier stops its scheduler, which deletes 60 // Stopping the invalidation notifier stops its scheduler, which deletes
60 // any pending tasks without running them. Some tasks "run and delete" 61 // any pending tasks without running them. Some tasks "run and delete"
61 // another task, so they must be run in order to avoid leaking the inner 62 // another task, so they must be run in order to avoid leaking the inner
(...skipping 12 matching lines...) Expand all
74 } 75 }
75 76
76 void TriggerOnIncomingInvalidation( 77 void TriggerOnIncomingInvalidation(
77 const ObjectIdInvalidationMap& invalidation_map) { 78 const ObjectIdInvalidationMap& invalidation_map) {
78 invalidator_->OnInvalidate(invalidation_map); 79 invalidator_->OnInvalidate(invalidation_map);
79 } 80 }
80 81
81 private: 82 private:
82 base::MessageLoop message_loop_; 83 base::MessageLoop message_loop_;
83 scoped_ptr<InvalidationNotifier> invalidator_; 84 scoped_ptr<InvalidationNotifier> invalidator_;
85
86 scoped_ptr<base::WeakPtrFactory<InvalidationStateTracker> >
87 invalidation_state_tracker_weak_ptr_factory_;
84 }; 88 };
85 89
86 INSTANTIATE_TYPED_TEST_CASE_P( 90 INSTANTIATE_TYPED_TEST_CASE_P(
87 InvalidationNotifierTest, InvalidatorTest, 91 InvalidationNotifierTest, InvalidatorTest,
88 InvalidationNotifierTestDelegate); 92 InvalidationNotifierTestDelegate);
89 93
90 } // namespace 94 } // namespace
91 95
92 } // namespace syncer 96 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698