Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2219593003: [content/test/gpu] Pushing the restart logic into start browser. (Closed)

Created:
4 years, 4 months ago by nednguyen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[content/test/gpu] Pushing the restart logic into start browser. This patch is done on behalf of eyaich@chromium.org (original work in https://codereview.chromium.org/2209673003). For reviewing this CL, the 1st patch set is the patch set 1 of https://codereview.chromium.org/2209673003. The 2nd patch set address some nits & add TODO for improve unittest logic. BUG=chromium:628022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/085c13919b7a8f7fb77e428a77df45bbc98978ae Cr-Commit-Position: refs/heads/master@{#409971}

Patch Set 1 : Patch from https://codereview.chromium.org/2209673003/#ps1 #

Patch Set 2 : Address few nits #

Patch Set 3 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -46 lines) Patch
M content/test/gpu/gpu_tests/gpu_integration_test.py View 1 2 chunks +22 lines, -9 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_integration_test_unittest.py View 1 2 7 chunks +75 lines, -37 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
nednguyen
4 years, 4 months ago (2016-08-05 01:42:38 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
4 years, 4 months ago (2016-08-05 01:43:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219593003/40001
4 years, 4 months ago (2016-08-05 01:48:20 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-05 02:33:21 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 02:34:48 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/085c13919b7a8f7fb77e428a77df45bbc98978ae
Cr-Commit-Position: refs/heads/master@{#409971}

Powered by Google App Engine
This is Rietveld 408576698