Elements using @apply shouldn't use the MatchedPropertiesCache

Elements using @apply shouldn't use the MatchedPropertiesCache

This patch disables the MatchedPropertiesCache on elements which use
@apply rules. We re-use the same flag as for when variables are
referenced from non-inherited properties because this is fundamentally
the same issue.

For elements with MatchedProperties in the cache but a different parent
ComputedStyle than is cached, we copy non-inherited properties directly
from the cache and apply only inherited properties. This doesn't work
when a non-inherited property depends on a parent's property and we
already disable this optimisation when a non-inherited property is set
to inherit or a variable reference. Similarly, using @apply can make
a non-inherited property depend on a parent's property by having the
@apply'd variable be inherited and setting a non-inherited property
with the rule.

BUG=633745
Committed: https://crrev.com/da555331c0bea26738d4c1ffe0b5fae8a706370b
Cr-Commit-Position: refs/heads/master@{#410578}

[Timothy Loh, 2016-08-05 03:49:49]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 03:50:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2016-08-05 03:50:08]

timloh@chromium.org changed reviewers:
+ meade@chromium.org, shans@chromium.org

[shans, 2016-08-05 03:54:02]

lgtm

[commit-bot: I haz the power, 2016-08-05 06:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 06:36:26]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-08-08 06:25:55]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-08-08 06:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meade_UTC10, 2016-08-08 06:53:56]

lgtm

https://codereview.chromium.org/2219543003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right):

https://codereview.chromium.org/2219543003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1437:
state.style()->setHasVariableReferenceFromNonInheritedProperty();
Do you get much from checking this before setting? Looks like this just ensures
the boolean is set to true.

[Timothy Loh, 2016-08-08 07:02:47]

The CQ bit was unchecked by timloh@chromium.org

[Timothy Loh, 2016-08-08 07:03:12]

https://codereview.chromium.org/2219543003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right):

https://codereview.chromium.org/2219543003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1437:
state.style()->setHasVariableReferenceFromNonInheritedProperty();
On 2016/08/08 06:53:56, Eddy wrote:
> Do you get much from checking this before setting? Looks like this just
ensures
> the boolean is set to true.

Mmm yeah I'll remove the check

[Timothy Loh, 2016-08-08 07:31:26]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2016-08-08 07:31:26]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
shans@chromium.org
Link to the patchset: https://codereview.chromium.org/2219543003/#ps20001
(title: "remove check")

[Timothy Loh, 2016-08-08 07:31:31]

The CQ bit was unchecked by timloh@chromium.org

[Timothy Loh, 2016-08-09 01:46:48]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:47:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 05:06:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-09 05:08:12]

Description was changed from

==========
Elements using @apply shouldn't use the MatchedPropertiesCache

This patch disables the MatchedPropertiesCache on elements which use
@apply rules. We re-use the same flag as for when variables are
referenced from non-inherited properties because this is fundamentally
the same issue.

For elements with MatchedProperties in the cache but a different parent
ComputedStyle than is cached, we copy non-inherited properties directly
from the cache and apply only inherited properties. This doesn't work
when a non-inherited property depends on a parent's property and we
already disable this optimisation when a non-inherited property is set
to inherit or a variable reference. Similarly, using @apply can make
a non-inherited property depend on a parent's property by having the
@apply'd variable be inherited and setting a non-inherited property
with the rule.

BUG=633745
==========

to

==========
Elements using @apply shouldn't use the MatchedPropertiesCache

This patch disables the MatchedPropertiesCache on elements which use
@apply rules. We re-use the same flag as for when variables are
referenced from non-inherited properties because this is fundamentally
the same issue.

For elements with MatchedProperties in the cache but a different parent
ComputedStyle than is cached, we copy non-inherited properties directly
from the cache and apply only inherited properties. This doesn't work
when a non-inherited property depends on a parent's property and we
already disable this optimisation when a non-inherited property is set
to inherit or a variable reference. Similarly, using @apply can make
a non-inherited property depend on a parent's property by having the
@apply'd variable be inherited and setting a non-inherited property
with the rule.

BUG=633745

Committed: https://crrev.com/da555331c0bea26738d4c1ffe0b5fae8a706370b
Cr-Commit-Position: refs/heads/master@{#410578}
==========

[commit-bot: I haz the power, 2016-08-09 05:08:13]

Patchset 2 (id:??) landed as
https://crrev.com/da555331c0bea26738d4c1ffe0b5fae8a706370b
Cr-Commit-Position: refs/heads/master@{#410578}