Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 221953005: Mojo: Mojom: Add basic lexer tests, and remove hex float constants. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Mojom: Add basic lexer tests, and remove hex float constants. (I'll probably remove a lot more soon, but I also want to commit this before I move files around.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -13 lines) Patch
M mojo/public/bindings/pylib/parse/mojo_lexer.py View 3 chunks +2 lines, -12 lines 0 comments Download
A mojo/public/bindings/pylib/parse/mojo_lexer_unittest.py View 1 chunk +159 lines, -0 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-03 03:43:22 UTC) #1
darin (slow to review)
Nice, LGTM
6 years, 8 months ago (2014-04-03 03:47:09 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-03 04:11:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/221953005/1
6 years, 8 months ago (2014-04-03 04:17:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:44 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:44 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-03 14:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/221953005/1
6 years, 8 months ago (2014-04-03 14:17:45 UTC) #8
viettrungluu
6 years, 8 months ago (2014-04-03 14:51:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r261385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698