Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 221953002: resize canvas for GM + typo (Closed)

Created:
6 years, 8 months ago by yunchao
Modified:
6 years, 8 months ago
Reviewers:
djsollen, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

resize canvas for GM + typo This change resized the canvas for some GM cases. It is better to show the visual difference in viewer.html for these cases after the CL applied. BUG=skia:2375 Committed: http://code.google.com/p/skia/source/detail?r=14177

Patch Set 1 : #

Patch Set 2 : code rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
M gm/aaclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/composeshader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/peekpixels.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkComposeShader.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yunchao
This change resized the canvas for some GM cases. It is better to show the ...
6 years, 8 months ago (2014-04-02 10:09:45 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-11 18:57:13 UTC) #2
yunchao
The CQ bit was checked by yunchao.he@intel.com
6 years, 8 months ago (2014-04-14 06:03:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/221953002/80001
6 years, 8 months ago (2014-04-14 06:03:39 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 15:02:27 UTC) #5
Message was sent while issue was closed.
Change committed as 14177

Powered by Google App Engine
This is Rietveld 408576698