Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2219473002: Skip initializing_formal_* tests on Dartium (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip initializing_formal_* tests on Dartium Apparently the VM does not get the --initializing-formal-access flag set, which these tests need in order to pass. TBR=terry BUG= Committed: https://github.com/dart-lang/sdk/commit/6075a535473b8b8b71ac0d1cfc638be752f82169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tests/language/language.status View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hausner
4 years, 4 months ago (2016-08-04 20:45:44 UTC) #3
hausner
Committed patchset #1 (id:1) manually as 6075a535473b8b8b71ac0d1cfc638be752f82169 (presubmit successful).
4 years, 4 months ago (2016-08-04 20:47:26 UTC) #5
eernst
On 2016/08/04 20:47:26, hausner wrote: > Committed patchset #1 (id:1) manually as > 6075a535473b8b8b71ac0d1cfc638be752f82169 (presubmit ...
4 years, 4 months ago (2016-08-05 08:58:36 UTC) #6
hausner
4 years, 4 months ago (2016-08-05 20:02:47 UTC) #7
Message was sent while issue was closed.
Thanks for the suggestion. I did consider it, but thought that skipping is
better. Being more specific about the kind of failure has the potential to just
adding more noise and false positives. Also, all the test coverage that is
needed is already there in the command line VM test suites.

Powered by Google App Engine
This is Rietveld 408576698