content/browser/ssl/ssl_policy.cc - Issue 2219463002: SSLPolicy::OnCertError: expired_previous_decision might be used uninitialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/ssl/ssl_policy.cc

Issue 2219463002: SSLPolicy::OnCertError: expired_previous_decision might be used uninitialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/ssl/ssl_policy.cc

diff --git a/content/browser/ssl/ssl_policy.cc b/content/browser/ssl/ssl_policy.cc

index e5df39ef24ae93a7cba18b103ea83d0212b67af0..a45e135d16c87e446221d4b35343abb796b75d01 100644

--- a/content/browser/ssl/ssl_policy.cc

+++ b/content/browser/ssl/ssl_policy.cc

@@ -43,7 +43,7 @@ SSLPolicy::SSLPolicy(SSLPolicyBackend* backend)

}

void SSLPolicy::OnCertError(SSLCertErrorHandler* handler) {

- bool expired_previous_decision;

+ bool expired_previous_decision = false;

// First we check if we know the policy for this error.

DCHECK(handler->ssl_info().is_valid());

SSLHostStateDelegate::CertJudgment judgment =

« no previous file with comments | « no previous file | no next file » | no next file with comments »