Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2219423002: [build] Fix mac asan dependencies (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix mac asan dependencies Remove dynamic libraries that are automatically included. BUG=chromium:644643 NOTRY=true Committed: https://crrev.com/860f6527d44ed05544a08a63adaab2650e06ed94 Cr-Commit-Position: refs/heads/master@{#39245}

Patch Set 1 #

Patch Set 2 : Remove dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/base.isolate View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Achenbach
Ptal
4 years, 3 months ago (2016-09-07 09:46:38 UTC) #3
vogelheim
lgtm
4 years, 3 months ago (2016-09-07 10:48:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219423002/20001
4 years, 3 months ago (2016-09-07 12:19:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 12:21:09 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 12:21:53 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/860f6527d44ed05544a08a63adaab2650e06ed94
Cr-Commit-Position: refs/heads/master@{#39245}

Powered by Google App Engine
This is Rietveld 408576698