third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h - Issue 2219393003: DevTools: Runtime.compileScript with persistScript = false should not report script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

Issue 2219393003: DevTools: Runtime.compileScript with persistScript = false should not report script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html ('K') | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

index c7ce2b3c71b4df611f198bf08fbe071a8448cc8c..4d967537d175c28806087b5e690bbb42f52c1ffc 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

@@ -85,6 +85,8 @@ public:

void asyncTaskFinished(void* task);

void allAsyncTasksCanceled();

+ void setIgnoreScriptParsedEvents(bool);

private:

void compileDebuggerScript();

v8::MaybeLocal<v8::Value> callDebuggerMethod(const char* functionName, int argc, v8::Local<v8::Value> argv[]);

@@ -112,6 +114,7 @@ private:

v8::Local<v8::Object> m_executionState;

v8::Local<v8::Context> m_pausedContext;

bool m_runningNestedMessageLoop;

+ bool m_ignoreScriptParsedEvents;

dgozman 2016/08/09 20:43:08 Let's do the counter to accommodate for nested loo

lushnikov 2016/08/09 22:24:29 Done.

using AsyncTaskToStackTrace = protocol::HashMap<void*, std::unique_ptr<V8StackTraceImpl>>;

AsyncTaskToStackTrace m_asyncTaskStacks;