Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2219373002: input[type=search]: Flip the position of cancel button in RTL. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

input[type=search]: Flip the position of cancel button in RTL. We didn't do it because Safari didn't. Safari recently changed the behavior. This CL removes a UA style to force LTR, and update some tests and WebUI style. BUG=67848 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7017637cecdd300f3a90f6afbde474ea4a98a418 Cr-Commit-Position: refs/heads/master@{#410495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -56 lines) Patch
M extensions/renderer/resources/extension.css View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/resources/common.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/search/search-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt View 7 chunks +20 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-rtl-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/search/search-rtl-expected.txt View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/html.css View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/webui/resources/css/widgets.css View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
tkent
keishi@, please review third_party/WebKit. dbeam@, please approve ui/webui/resources/css/widget.css mek@, please approve extensions/renderer/resources/extension.css
4 years, 4 months ago (2016-08-08 05:51:32 UTC) #17
keishi
LGTM
4 years, 4 months ago (2016-08-08 06:47:10 UTC) #20
Marijn Kruisselbrink
extensions lgtm
4 years, 4 months ago (2016-08-08 16:57:35 UTC) #21
Dan Beam
lgtm
4 years, 4 months ago (2016-08-08 17:09:29 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219373002/60001
4 years, 4 months ago (2016-08-08 23:18:41 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 4 months ago (2016-08-08 23:24:22 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 23:26:23 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7017637cecdd300f3a90f6afbde474ea4a98a418
Cr-Commit-Position: refs/heads/master@{#410495}

Powered by Google App Engine
This is Rietveld 408576698