Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2219343002: finish SkLiteDL (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

finish SkLiteDL - makeThreadsafe() - fix up some alignment problems - drawVertices / drawPatch - work around drawPicture() + default paint bugs? - turn on tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219343002 Committed: https://skia.googlesource.com/skia/+/03591a762c0e3f541141d570625c2dab16deacba

Patch Set 1 #

Patch Set 2 : just bugs to go #

Patch Set 3 : picture has_paint fixes remaining diffs #

Patch Set 4 : test on GCE bots #

Patch Set 5 : skip drawfilter, skia:4769 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -39 lines) Patch
M dm/DMSrcSink.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.py View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-AndroidOne-GPU-Mali400MP2-Arm7-Release.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-Nexus9-CPU-Denver-Arm64-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-GCC-NexusPlayer-CPU-SSE4-x86-Release.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/adb_in_path.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skimage.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/download_and_push_skps.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkLiteDL.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkLiteDL.cpp View 1 2 15 chunks +146 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mtklein
lgtm
4 years, 4 months ago (2016-08-07 20:02:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219343002/60001
4 years, 4 months ago (2016-08-07 20:02:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/10400)
4 years, 4 months ago (2016-08-07 20:12:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219343002/70001
4 years, 4 months ago (2016-08-07 20:18:29 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-07 20:35:53 UTC) #15
Message was sent while issue was closed. 
Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/03591a762c0e3f541141d570625c2dab16deacba

Powered by Google App Engine
This is Rietveld 408576698