Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2219333002:
DevTools: Fix "Run Snippet" button not showing when viewing a snippet right after opening DevTools (Closed)
|
Created:
4 years, 4 months ago by Matt Zeunert Modified:
4 years, 4 months ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix "Run Snippet" button not showing when viewing a snippet right after
opening DevTools.
The SourcesPanel isn't aware that the snippet is displayed because it
only starts listening to "EditorSelected" events after the SourcesView
has already been initialized.
With this change SourcesPanel explicitly requests the file that's
being displayed after initializing SourcesView and then updates the UI
accordingly.
BUG=635309
Committed: https://crrev.com/df25833b11f3e555df4550792b2e6a6c8a9be3a5
Cr-Commit-Position: refs/heads/master@{#411003}
Patch Set 1 #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== Fix run snippet button not showing up. BUG= ========== to ========== Fix "Run Snippet" button not showing when viewing a snippet right after opening DevTools. The SourcesPanel isn't aware that the snippet is displayed because it only starts listening to "EditorSelected" events after the SourcesView has already been initialized. With this change SourcesPanel explicitly requests the file that's being displayed after initializing SourcesView and then updates the UI accordingly. BUG=635309 ==========
matt@mostlystatic.com changed reviewers: + paulirish@chromium.com, pfeldman@chromium.com
PTAL
paulirish@chromium.org changed reviewers: + lushnikov@chromium.org, paulirish@chromium.org
Nice. Thanks for the patch. We'll likely take a look at it tomorrow.
lgtm, thank you! nit: please, prepend issue description with "DevTools:" prefix.
The CQ bit was checked by paulirish@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by matt@mostlystatic.com
The CQ bit was unchecked by matt@mostlystatic.com
The CQ bit was checked by matt@mostlystatic.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by matt@mostlystatic.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix "Run Snippet" button not showing when viewing a snippet right after opening DevTools. The SourcesPanel isn't aware that the snippet is displayed because it only starts listening to "EditorSelected" events after the SourcesView has already been initialized. With this change SourcesPanel explicitly requests the file that's being displayed after initializing SourcesView and then updates the UI accordingly. BUG=635309 ========== to ========== Fix "Run Snippet" button not showing when viewing a snippet right after opening DevTools. The SourcesPanel isn't aware that the snippet is displayed because it only starts listening to "EditorSelected" events after the SourcesView has already been initialized. With this change SourcesPanel explicitly requests the file that's being displayed after initializing SourcesView and then updates the UI accordingly. BUG=635309 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix "Run Snippet" button not showing when viewing a snippet right after opening DevTools. The SourcesPanel isn't aware that the snippet is displayed because it only starts listening to "EditorSelected" events after the SourcesView has already been initialized. With this change SourcesPanel explicitly requests the file that's being displayed after initializing SourcesView and then updates the UI accordingly. BUG=635309 ========== to ========== Fix "Run Snippet" button not showing when viewing a snippet right after opening DevTools. The SourcesPanel isn't aware that the snippet is displayed because it only starts listening to "EditorSelected" events after the SourcesView has already been initialized. With this change SourcesPanel explicitly requests the file that's being displayed after initializing SourcesView and then updates the UI accordingly. BUG=635309 Committed: https://crrev.com/df25833b11f3e555df4550792b2e6a6c8a9be3a5 Cr-Commit-Position: refs/heads/master@{#411003} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/df25833b11f3e555df4550792b2e6a6c8a9be3a5 Cr-Commit-Position: refs/heads/master@{#411003} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
