Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 221933012: android envsetup: Stop exporting ANDROID_NDK_ROOT. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
Philippe
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

android envsetup: Stop exporting ANDROID_NDK_ROOT. Change its only user, adb_gdb, to instead use pylib.constants. BUG=330631 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261437

Patch Set 1 #

Patch Set 2 : wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M build/android/adb_gdb View 1 2 chunks +3 lines, -10 lines 0 comments Download
M build/android/envsetup.sh View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 8 months ago (2014-04-02 21:51:59 UTC) #1
Philippe
lgtm, thanks Nico!
6 years, 8 months ago (2014-04-03 07:18:49 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-03 15:22:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/221933012/20001
6 years, 8 months ago (2014-04-03 15:22:08 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:13:38 UTC) #5
Message was sent while issue was closed.
Change committed as 261437

Powered by Google App Engine
This is Rietveld 408576698