Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2219303002: [ic] Don't share LoadGlobalIC slots inside typeof and outside typeof. (Closed)

Created:
4 years, 4 months ago by Igor Sheludko
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Don't share LoadGlobalIC slots inside typeof and outside typeof. Because in case of interceptors we will install a slow stub that suits only one case. BUG=chromium:634467 TBR=verwaest@chromium.org Committed: https://crrev.com/d634e65fb07fb7c3a79680237c5e90a9fae6645c Cr-Commit-Position: refs/heads/master@{#38503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M src/ast/ast-numbering.cc View 4 chunks +11 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Igor Sheludko
PTAL
4 years, 4 months ago (2016-08-07 20:14:26 UTC) #6
Igor Sheludko
On 2016/08/07 20:14:26, Igor Sheludko wrote: > PTAL Another option would be to merge LoadGlobalIC_SlowInsideTypeof ...
4 years, 4 months ago (2016-08-08 01:46:19 UTC) #7
Igor Sheludko
Jakob, PTAL
4 years, 4 months ago (2016-08-09 15:56:24 UTC) #9
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-09 15:58:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219303002/1
4 years, 4 months ago (2016-08-09 16:10:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21429)
4 years, 4 months ago (2016-08-09 16:12:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219303002/1
4 years, 4 months ago (2016-08-09 16:26:53 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 16:30:33 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 16:30:54 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d634e65fb07fb7c3a79680237c5e90a9fae6645c
Cr-Commit-Position: refs/heads/master@{#38503}

Powered by Google App Engine
This is Rietveld 408576698