Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 22193002: Enable SkUtilsArm on all ARM platforms and always use NDK compliant NEON dectection. (Closed)

Created:
7 years, 4 months ago by djsollen
Modified:
7 years, 4 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Enable SkUtilsArm on all ARM platforms and always use NDK compliant NEON detection on Android. R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=10530

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix missing dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M gyp/core.gyp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/core/SkUtilsArm.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
djsollen
This should replace the need for https://codereview.chromium.org/21120006/
7 years, 4 months ago (2013-08-05 13:11:03 UTC) #1
scroggo
https://codereview.chromium.org/22193002/diff/1/gyp/core.gyp File gyp/core.gyp (left): https://codereview.chromium.org/22193002/diff/1/gyp/core.gyp#oldcode86 gyp/core.gyp:86: '../src/core/SkPaintOptionsAndroid.cpp', Do we no longer need to compile this ...
7 years, 4 months ago (2013-08-05 13:23:09 UTC) #2
djsollen
https://codereview.chromium.org/22193002/diff/1/gyp/core.gyp File gyp/core.gyp (left): https://codereview.chromium.org/22193002/diff/1/gyp/core.gyp#oldcode86 gyp/core.gyp:86: '../src/core/SkPaintOptionsAndroid.cpp', On 2013/08/05 13:23:09, scroggo wrote: > Do we ...
7 years, 4 months ago (2013-08-05 13:27:22 UTC) #3
scroggo
lgtm
7 years, 4 months ago (2013-08-05 13:29:03 UTC) #4
scroggo
On 2013/08/05 13:29:03, scroggo wrote: > lgtm Also lgtm at patch set 2
7 years, 4 months ago (2013-08-05 13:37:56 UTC) #5
djsollen
Committed patchset #2 manually as r10530 (presubmit successful).
7 years, 4 months ago (2013-08-05 13:38:31 UTC) #6
mtklein
7 years, 4 months ago (2013-08-05 15:03:10 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698