Remove more vestigial CONST_LEGACY support and clean up var declaration code

Remove more vestigial CONST_LEGACY support and clean up var declaration code

%InitializeConstGlobal has been dead code since the demise of legacy const
declarations. While getting rid of that call, also cleaned up and clarified
the surrounding code in a variety of ways.

R=neis@chromium.org

Committed: https://crrev.com/49f509448c4026980041b5ddb2861e76ef36c63c
Cr-Commit-Position: refs/heads/master@{#38457}

[adamk, 2016-08-06 00:05:43]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 00:05:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:30:44]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-08 15:26:30]

adamk@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[adamk, 2016-08-08 15:26:31]

+mstarzinger for legacy const knowledge

[adamk, 2016-08-08 17:26:57]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org
- neis@chromium.org

[adamk, 2016-08-08 17:26:58]

+littledan

[Michael Starzinger, 2016-08-08 17:43:50]

Not really familiar with the pattern rewriter. You might want to choose another
reviewer for that piece. But rubber-stamp LGTM on the runtime function removal.

[Dan Ehrenberg, 2016-08-08 18:04:16]

lgtm

Yay!

[adamk, 2016-08-08 18:06:46]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-08-08 18:06:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 19:18:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-08 19:24:51]

Description was changed from

==========
Remove more vestigial CONST_LEGACY support and clean up var declaration code

%InitializeConstGlobal has been dead code since the demise of legacy const
declarations. While getting rid of that call, also cleaned up and clarified
the surrounding code in a variety of ways.

R=neis@chromium.org
==========

to

==========
Remove more vestigial CONST_LEGACY support and clean up var declaration code

%InitializeConstGlobal has been dead code since the demise of legacy const
declarations. While getting rid of that call, also cleaned up and clarified
the surrounding code in a variety of ways.

R=neis@chromium.org

Committed: https://crrev.com/49f509448c4026980041b5ddb2861e76ef36c63c
Cr-Commit-Position: refs/heads/master@{#38457}
==========

[commit-bot: I haz the power, 2016-08-08 19:24:52]

Patchset 1 (id:??) landed as
https://crrev.com/49f509448c4026980041b5ddb2861e76ef36c63c
Cr-Commit-Position: refs/heads/master@{#38457}