Add support to Document::URL property getter.

Add support to Document::URL property getter.

As per the PDF specification at [1]

"
This property specifies the document's URL.
".

IE/Acrobat supports it, and getting it implemented
would be one step forward in order to support Acrobat JS
script as the one in [2].

[1] http://partners.adobe.com/public/developer/en/acrobat/sdk/5186AcroJS.pdf
[2] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=492
Committed: https://pdfium.googlesource.com/pdfium/+/33c4cdb4efbacb73151c982549151ea4e545eff8

[tonikitoo, 2016-08-06 21:04:24]

tonikitoo@igalia.com changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[tonikitoo, 2016-08-06 21:04:25]

PTAL.

[tonikitoo, 2016-08-08 13:04:24]

Description was changed from

==========
Add support to Document::URL property getter.

As per the PDF specification at [1]

"
This property specifies the document's URL.
".

IE/Acrobat supports it, and getting it implemented
would be one step forward in order to support Acrobat JS
script as the one in [2].

[1] http://partners.adobe.com/public/developer/en/acrobat/sdk/5186AcroJS.pdf
[2] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=492
==========

to

==========
Add support to Document::URL property getter.

As per the PDF specification at [1]

"
This property specifies the document's URL.
".

IE/Acrobat supports it, and getting it implemented
would be one step forward in order to support Acrobat JS
script as the one in [2].

[1] http://partners.adobe.com/public/developer/en/acrobat/sdk/5186AcroJS.pdf
[2] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=492
==========

[tonikitoo, 2016-08-08 13:04:24]

tonikitoo@igalia.com changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2016-08-08 14:06:12]

The code lg to me. tsepez@ are there any security considerations with exposing
the URL?

[Tom Sepez, 2016-08-08 15:58:59]

On 2016/08/08 14:06:12, dsinclair wrote:
> The code lg to me. tsepez@ are there any security considerations with exposing
> the URL?

I can't think of any.  LGTM.

[tonikitoo, 2016-08-08 16:00:08]

The CQ bit was checked by tonikitoo@igalia.com

[commit-bot: I haz the power, 2016-08-08 16:00:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-08 16:01:01]

Thanks! for the patch.

https://codereview.chromium.org/2219183002/diff/20001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2219183002/diff/20001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:916: CFX_WideString wsFilePath =
m_pDocument->GetPath();
nit: local not required, we can write 
  vp << m_pDocument->GetPath();

[tonikitoo, 2016-08-08 16:03:19]

The CQ bit was unchecked by tonikitoo@igalia.com

[tonikitoo, 2016-08-08 16:04:15]

On 2016/08/08 16:01:01, Tom Sepez wrote:
> Thanks! for the patch.

Thanks for the review, Dan/Tom.
 
>
https://codereview.chromium.org/2219183002/diff/20001/fpdfsdk/javascript/Docu...
> File fpdfsdk/javascript/Document.cpp (right):
> 
>
https://codereview.chromium.org/2219183002/diff/20001/fpdfsdk/javascript/Docu...
> fpdfsdk/javascript/Document.cpp:916: CFX_WideString wsFilePath =
> m_pDocument->GetPath();
> nit: local not required, we can write 
>   vp << m_pDocument->GetPath();

Yep, will upload a revised patch, and cq it.

[tonikitoo, 2016-08-08 17:40:48]

The CQ bit was checked by tonikitoo@igalia.com

[tonikitoo, 2016-08-08 17:40:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2219183002/#ps40001
(title: "Add support to Document::URL property getter.")

[commit-bot: I haz the power, 2016-08-08 17:40:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 17:52:55]

Description was changed from

==========
Add support to Document::URL property getter.

As per the PDF specification at [1]

"
This property specifies the document's URL.
".

IE/Acrobat supports it, and getting it implemented
would be one step forward in order to support Acrobat JS
script as the one in [2].

[1] http://partners.adobe.com/public/developer/en/acrobat/sdk/5186AcroJS.pdf
[2] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=492
==========

to

==========
Add support to Document::URL property getter.

As per the PDF specification at [1]

"
This property specifies the document's URL.
".

IE/Acrobat supports it, and getting it implemented
would be one step forward in order to support Acrobat JS
script as the one in [2].

[1] http://partners.adobe.com/public/developer/en/acrobat/sdk/5186AcroJS.pdf
[2] https://bugs.chromium.org/p/pdfium/issues/detail?id=492

BUG=492

Committed:
https://pdfium.googlesource.com/pdfium/+/33c4cdb4efbacb73151c982549151ea4e545...
==========

[commit-bot: I haz the power, 2016-08-08 17:52:57]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/33c4cdb4efbacb73151c982549151ea4e545...