Re-land "Disable Print in the context menu when a modal dialog is shown"

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <set>
@@ skipping 1565 matching lines @@
 
     case IDC_CONTENT_CONTEXT_SELECTALL:
       return !!(params_.edit_flags & WebContextMenuData::CanSelectAll);
 
     case IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD:
       return !browser_context_->IsOffTheRecord() &&
              params_.link_url.is_valid() &&
              incognito_avail != IncognitoModePrefs::DISABLED;
 
     case IDC_PRINT:
-      return prefs->GetBoolean(prefs::kPrintingEnabled) &&
-             (params_.media_type == WebContextMenuData::MediaTypeNone ||
-              params_.media_flags & WebContextMenuData::MediaCanPrint);
+      return IsPrintPreviewEnabled();
 
     case IDC_CONTENT_CONTEXT_SEARCHWEBFOR:
     case IDC_CONTENT_CONTEXT_GOTOURL:
     case IDC_SPELLPANEL_TOGGLE:
     case IDC_CONTENT_CONTEXT_LANGUAGE_SETTINGS:
       return true;
     case IDC_CHECK_SPELLING_WHILE_TYPING:
       return prefs->GetBoolean(prefs::kEnableContinuousSpellcheck);
 
 #if !defined(OS_MACOSX) && defined(OS_POSIX)
@@ skipping 476 matching lines @@
 
 bool RenderViewContextMenu::IsPasteAndMatchStyleEnabled() const {
   if (!(params_.edit_flags & WebContextMenuData::CanPaste))
     return false;
 
   return ui::Clipboard::GetForCurrentThread()->IsFormatAvailable(
       ui::Clipboard::GetPlainTextFormatType(),
       ui::CLIPBOARD_TYPE_COPY_PASTE);
 }
 
+bool RenderViewContextMenu::IsPrintPreviewEnabled() const {
+  if (params_.media_type != WebContextMenuData::MediaTypeNone &&
+      !(params_.media_flags & WebContextMenuData::MediaCanPrint)) {
+    return false;
+  }
+
+  // |browser| is a nullptr if a modal dialog is open.
+  Browser* browser = chrome::FindBrowserWithWebContents(source_web_contents_);

[Lei Zhang, 2016/08/05 22:48:08]

Because the PDF plugin is a guest, passing in |embedder_web_contents_| here
works.

[lazyboy, 2016/08/06 00:27:22]

Anything depending on Browser* can/should use GetWebContentsToUse().
I'm guessing fullscreen related logic will work for that too.
Maybe we should add RVContextMenu::GetBrowser() that can use
GetWebContentsToUse() to return the Browser*?

[takumif, 2016/08/08 19:08:11]

The browser stays the same for the lifetime of the RVContextMenu, right?
Can/should we just have a |browser_| attribute that we initialize with
chrome::FindBrowserWithWebContents(embedder_web_contents_) in the constructor?

+  return browser && chrome::CanPrint(browser);
+}
+
 bool RenderViewContextMenu::IsRouteMediaEnabled() const {
   if (!media_router::MediaRouterEnabled(browser_context_))
     return false;
 
   Browser* browser = chrome::FindBrowserWithWebContents(source_web_contents_);
   if (!browser)
     return false;
 
   // Disable the command if there is an active modal dialog.
   // We don't use |source_web_contents_| here because it could be the
@@ skipping 343 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }