third_party/WebKit/Source/core/layout/LayoutTableSection.cpp - Issue 2219153002: Offset repeating theads correctly when two tables adjoin at a page border

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2219153002: Offset repeating theads correctly when two tables adjoin at a page border (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug 634404 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.cpp ('k') | third_party/WebKit/Source/core/paint/TableSectionPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

index 0b6d3015034d2a1baf9e95a3ca91de146d70c8b2..1d593fd3bd57ce1ad246fc87ce8f46734187073e 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

@@ -1135,6 +1135,8 @@ void LayoutTableSection::layoutRows()

int LayoutTableSection::paginationStrutForRow(LayoutTableRow* row, LayoutUnit logicalOffset) const

{

+ if (!row)

mstensho (USE GERRIT) 2016/08/12 08:36:59 Why would you ever want to pass a null pointer? Be

rhogan 2016/08/12 18:39:48 Sure - updated.

+ return 0;

// Even if the row allows us to break-inside, we will want to put a strut on the row if we have a header

// group that wants to appear at the top of each page.

bool tableHeaderForcesStrut = table()->header() ? table()->header()->getPaginationBreakability() != AllowAnyBreaks : false;