Add a --virtual-time-budget option to headless_shell

Add a --virtual-time-budget option to headless_shell

This is an alternative to waiting for the DomContentLoaded event, where you specify a virtual time budget in milliseconds.

BUG=546953
Committed: https://crrev.com/d12a9b250656e0528e3459f82518852122daf9b9
Cr-Commit-Position: refs/heads/master@{#410459}

[alex clarke (OOO till 29th), 2016-08-05 20:22:09]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-08-08 10:12:29]

Very useful, thanks. lgtm, although I've got one suggestion.

https://codereview.chromium.org/2219143002/diff/1/headless/app/headless_shell.cc
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2219143002/diff/1/headless/app/headless_shell...
headless/app/headless_shell.cc:129: .SetBudget(10000)  // 10 virtual seconds
Mind making this configurable so that you could say --virtual-time=NN?

[alex clarke (OOO till 29th), 2016-08-08 20:07:38]

Description was changed from

==========
Add a --virtual-time option to headless_shell

BUG=546953
==========

to

==========
Add a --virtual-time-budget option to headless_shell

This is an alternative to waiting for the DomContentLoaded event, where you
specify a virtual time budget in milliseconds.

BUG=546953
==========

[alex clarke (OOO till 29th), 2016-08-08 20:28:01]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-08-08 20:28:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2219143002/#ps40001
(title: "Fix compile")

[alex clarke (OOO till 29th), 2016-08-08 20:28:12]

https://codereview.chromium.org/2219143002/diff/1/headless/app/headless_shell.cc
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2219143002/diff/1/headless/app/headless_shell...
headless/app/headless_shell.cc:129: .SetBudget(10000)  // 10 virtual seconds
On 2016/08/08 10:12:28, Sami wrote:
> Mind making this configurable so that you could say --virtual-time=NN?

Done.

[commit-bot: I haz the power, 2016-08-08 20:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 21:13:35]

Description was changed from

==========
Add a --virtual-time-budget option to headless_shell

This is an alternative to waiting for the DomContentLoaded event, where you
specify a virtual time budget in milliseconds.

BUG=546953
==========

to

==========
Add a --virtual-time-budget option to headless_shell

This is an alternative to waiting for the DomContentLoaded event, where you
specify a virtual time budget in milliseconds.

BUG=546953
==========

[commit-bot: I haz the power, 2016-08-08 21:13:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 21:15:51]

Description was changed from

==========
Add a --virtual-time-budget option to headless_shell

This is an alternative to waiting for the DomContentLoaded event, where you
specify a virtual time budget in milliseconds.

BUG=546953
==========

to

==========
Add a --virtual-time-budget option to headless_shell

This is an alternative to waiting for the DomContentLoaded event, where you
specify a virtual time budget in milliseconds.

BUG=546953

Committed: https://crrev.com/d12a9b250656e0528e3459f82518852122daf9b9
Cr-Commit-Position: refs/heads/master@{#410459}
==========

[commit-bot: I haz the power, 2016-08-08 21:15:52]

Patchset 3 (id:??) landed as
https://crrev.com/d12a9b250656e0528e3459f82518852122daf9b9
Cr-Commit-Position: refs/heads/master@{#410459}