Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 221913004: Allow flags strings in quotes. (Closed)

Created:
6 years, 8 months ago by marja
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Allow flags strings in quotes. If the user wants to run Chromium and pass several js flags to V8, the command line would be: chrome --js-flags="--foo --bar" In this case, the value of the flag is "--foo --bar" (including quotes; this is conceptually correct), but V8 doesn't parse this properly. This CL fixes SetFlagsFromString to handle quotes. R=yangguo@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/flags.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
yangguo, wdyt? An alternative solution would be fix all callers, but I think this is ...
6 years, 8 months ago (2014-04-02 14:54:23 UTC) #1
Yang
6 years, 8 months ago (2014-04-02 15:19:30 UTC) #2
On 2014/04/02 14:54:23, marja wrote:
> yangguo, wdyt?
> 
> An alternative solution would be fix all callers, but I think this is more
> correct.

lgtm.

Powered by Google App Engine
This is Rietveld 408576698