Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 22191002: Make ClientRectList.item() argument mandatory and drop [IsIndex] (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, lgombos, jsbell
Visibility:
Public.

Description

Make ClientRectList.item() argument mandatory and drop [IsIndex] Make ClientRectList.item() argument mandatory and drop [IsIndex] IDL extended attribute to match the latest specification: http://dev.w3.org/csswg/cssom-view/#dom-clientrectlist-item According to the specification, the index argument for ClientRectList.item() is mandatory and we should not throw when the index is negative, as long as it wraps to a valid index value (when calling toUInt32() as per Web IDL specification). Our new behavior is consistent with Firefox 22 as well. Note however that IE10 behaves differently: the argument is optional and passing a negative index throws even if it wraps to a valid index. Note that according to the specification, we should throw an IndexSizeError exception when index is greater than the number of ClientRect objects associated with the object. Blink just returns null in this case and this patch does not change this behavior as it is consistent with Firefox 22. IE10 does throw in this case though. BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1 line) Patch
A LayoutTests/fast/dom/Element/client-rect-list-argument.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Element/client-rect-list-argument-expected.txt View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/dom/ClientRectList.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-05 12:33:50 UTC) #1
haraken
What about Opera?
7 years, 4 months ago (2013-08-05 12:43:42 UTC) #2
do-not-use
On 2013/08/05 12:43:42, haraken wrote: > What about Opera? Isn't Opera using Blink now? Or ...
7 years, 4 months ago (2013-08-05 12:52:54 UTC) #3
haraken
On 2013/08/05 12:52:54, Christophe Dumez wrote: > On 2013/08/05 12:43:42, haraken wrote: > > What ...
7 years, 4 months ago (2013-08-05 12:56:27 UTC) #4
haraken
On 2013/08/05 12:52:54, Christophe Dumez wrote: > On 2013/08/05 12:43:42, haraken wrote: > > What ...
7 years, 4 months ago (2013-08-05 12:56:27 UTC) #5
arv (Not doing code reviews)
LGTM
7 years, 4 months ago (2013-08-05 13:54:00 UTC) #6
tkent
lgtm IE10 behavior sounds unreasonable...
7 years, 4 months ago (2013-08-05 22:31:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22191002/1
7 years, 4 months ago (2013-08-06 06:30:10 UTC) #8
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 08:05:59 UTC) #9
Message was sent while issue was closed.
Change committed as 155588

Powered by Google App Engine
This is Rietveld 408576698