Update GN toolchain_args to be a variable.

Update GN toolchain_args to be a variable.

This makes toolchain_args on a toolchain definition a variable instead of a function call.

The function call is kept for backwards compatibility (for now) and it just sets the variable.

forward_variables_from now accepts a first parameter of any type that evaluates to a scope, which allows things like "invoker.toolchain_args" to be used there.

Updates "gn format" to format scope assignments without extra indents.

BUG=634446
Committed: https://crrev.com/22227896dc68aa88ba1836cd53fd261ba21bef88
Cr-Commit-Position: refs/heads/master@{#410123}

[brettw, 2016-08-05 17:10:00]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2016-08-05 17:10:01]

This will make this patch possible:
https://codereview.chromium.org/2219953002

[brettw, 2016-08-05 17:10:05]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 17:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 17:13:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-08-05 17:22:52]

lgtm

[brettw, 2016-08-05 17:39:17]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-08-05 17:39:17]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2219083002/#ps20001
(title: "Merge remote-tracking branch 'origin/master' into toolchain_args")

[commit-bot: I haz the power, 2016-08-05 17:39:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 19:05:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-05 19:08:59]

Description was changed from

==========
Update GN toolchain_args to be a variable.

This makes toolchain_args on a toolchain definition a variable instead of a
function call.

The function call is kept for backwards compatibility (for now) and it just sets
the variable.

forward_variables_from now accepts a first parameter of any type that evaluates
to a scope, which allows things like "invoker.toolchain_args" to be used there.

Updates "gn format" to format scope assignments without extra indents.

BUG=634446
==========

to

==========
Update GN toolchain_args to be a variable.

This makes toolchain_args on a toolchain definition a variable instead of a
function call.

The function call is kept for backwards compatibility (for now) and it just sets
the variable.

forward_variables_from now accepts a first parameter of any type that evaluates
to a scope, which allows things like "invoker.toolchain_args" to be used there.

Updates "gn format" to format scope assignments without extra indents.

BUG=634446

Committed: https://crrev.com/22227896dc68aa88ba1836cd53fd261ba21bef88
Cr-Commit-Position: refs/heads/master@{#410123}
==========

[commit-bot: I haz the power, 2016-08-05 19:09:00]

Patchset 2 (id:??) landed as
https://crrev.com/22227896dc68aa88ba1836cd53fd261ba21bef88
Cr-Commit-Position: refs/heads/master@{#410123}

[Dirk Pranke, 2016-08-08 20:46:17]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-08 20:46:18]

lgtm.