Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 221903007: Check if the drag state is still valid when folder reparent folder timer fires. (Closed)

Created:
6 years, 8 months ago by jennyz
Modified:
6 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, calamity
Visibility:
Public.

Description

Check if the drag state is still valid when folder reparent folder timer fires. BUG=359213 R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jennyz
6 years, 8 months ago (2014-04-02 22:15:36 UTC) #1
xiyuan
lgtm
6 years, 8 months ago (2014-04-02 22:31:20 UTC) #2
jennyz
6 years, 8 months ago (2014-04-02 23:16:42 UTC) #3
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 8 months ago (2014-04-02 23:16:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/221903007/1
6 years, 8 months ago (2014-04-02 23:17:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 00:14:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-03 00:14:40 UTC) #7
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 8 months ago (2014-04-03 17:52:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/221903007/1
6 years, 8 months ago (2014-04-03 17:53:24 UTC) #9
jennyz
6 years, 8 months ago (2014-04-03 18:11:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r261477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698