Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 221903004: ARM64: Fix cctest/test-disasm-arm64/debug on real hardware. (Closed)

Created:
6 years, 8 months ago by Alexandre Rames
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Fix cctest/test-disasm-arm64/debug on real hardware. Without the 'BREAK' parameter, no instruction is generated when we are not running with the simulator. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M test/cctest/test-disasm-arm64.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
6 years, 8 months ago (2014-04-02 15:28:19 UTC) #1
ulan
lgtm
6 years, 8 months ago (2014-04-02 15:29:28 UTC) #2
Alexandre Rames
6 years, 8 months ago (2014-04-02 15:45:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698