Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2219004: Rearrange vboot_reference directories to isolate external components. (Closed)

Created:
10 years, 7 months ago by Bill Richardson
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Rearrange vboot_reference directories to isolate external components. This creates a new vboot_firmware subdirectory, and which contains the entirety of the BIOS code. There shouldn't be anything in this directory that is NOT required by the BIOS.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -57 lines) Patch
M src/platform/vboot_reference/Makefile View 1 chunk +5 lines, -3 lines 0 comments Download
M src/platform/vboot_reference/cgptlib/tests/Makefile View 1 chunk +1 line, -1 line 0 comments Download
D src/platform/vboot_reference/common/Makefile View 1 chunk +0 lines, -18 lines 0 comments Download
D src/platform/vboot_reference/cryptolib/Makefile View 1 chunk +0 lines, -23 lines 0 comments Download
M src/platform/vboot_reference/misclibs/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/tests/Makefile View 2 chunks +7 lines, -11 lines 0 comments Download
M src/platform/vboot_reference/utility/Makefile View 3 chunks +10 lines, -16 lines 0 comments Download
M src/platform/vboot_reference/utility/cgpt/Makefile View 1 chunk +1 line, -2 lines 0 comments Download
A src/platform/vboot_reference/vboot_firmware/Makefile View 1 chunk +44 lines, -0 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/boot_device.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/firmware_image_fw.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/kernel_image_fw.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/load_kernel_fw.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/rollback_index.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/tlcl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/include/utility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/include/cryptolib.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/include/padding.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/include/rsa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/include/sha.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/padding.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/rsa.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/rsa_utility.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/sha1.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/sha2.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/cryptolib/sha_utility.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/include/tss_constants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/kernel_image_fw.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/rollback_index.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/lib/tlcl.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/vboot_firmware/linktest/main.c View 1 chunk +55 lines, -0 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/stub/boot_device_stub.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vboot_firmware/stub/utility_stub.c View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/platform/vboot_reference/vfirmware/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform/vboot_reference/vkernel/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Richardson
10 years, 7 months ago (2010-05-25 23:41:21 UTC) #1
Randall Spangler
LGTM Please also update README to describe the new organization (i.e., every file in vboot_reference ...
10 years, 7 months ago (2010-05-26 02:07:00 UTC) #2
gauravsh
10 years, 7 months ago (2010-05-26 11:45:34 UTC) #3 
LGTM too. Thanks for doing this!

On 2010/05/25 23:41:21, Bill Richardson wrote:
>

Powered by Google App Engine
This is Rietveld 408576698