Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated mpearson@'s comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
index cf3adabf5dc9e9e12811eea5d7fca6b8b7058b24..fce2bd91f14130f7b4e0532befb8f60dc72facb0 100644
--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h
@@ -112,11 +112,11 @@ public:
virtual WebDevToolsAgentClient::WebKitClientMessageLoop* createDevToolsMessageLoop() { return nullptr; }
// ServiceWorker specific method.
- virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// Called after ExtendableMessageEvent is handled by the ServiceWorker's
// script context.
- virtual void didHandleExtendableMessageEvent(int eventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleExtendableMessageEvent(int eventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// ServiceWorker specific methods. respondFetchEvent will be called after
// FetchEvent returns a response by the ServiceWorker's script context, and
@@ -124,34 +124,34 @@ public:
// lifecycle. When no response is provided, the browser should fallback to
// native fetch. EventIDs are the same with the ids passed from
// dispatchFetchEvent respectively.
- virtual void respondToFetchEvent(int responseID) { };
- virtual void respondToFetchEvent(int responseID, const WebServiceWorkerResponse& response) { };
- virtual void didHandleFetchEvent(int eventFinishID, WebServiceWorkerEventResult result) { };
+ virtual void respondToFetchEvent(int responseID, double eventDispatchTime) {}
+ virtual void respondToFetchEvent(int responseID, const WebServiceWorkerResponse& response, double eventDispatchTime) {}
+ virtual void didHandleFetchEvent(int eventFinishID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// ServiceWorker specific method. Called after InstallEvent (dispatched
// via WebServiceWorkerContextProxy) is handled by the ServiceWorker's
// script context.
- virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// ServiceWorker specific method. Called after NotificationClickEvent
// (dispatched via WebServiceWorkerContextProxy) is handled by the
// ServiceWorker's script context.
- virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleNotificationClickEvent(int eventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// ServiceWorker specific method. Called after NotificationCloseEvent
// (dispatched via WebServiceWorkerContextProxy) is handled by the
// ServiceWorker's script context.
- virtual void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// ServiceWorker specific method. Called after PushEvent (dispatched via
// WebServiceWorkerContextProxy) is handled by the ServiceWorker's script
// context.
- virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// ServiceWorker specific method. Called after SyncEvent (dispatched via
// WebServiceWorkerContextProxy) is handled by the ServiceWorker's script
// context.
- virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult result) { }
+ virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult result, double eventDispatchTime) {}
// Ownership of the returned object is transferred to the caller.
// This is called on the main thread.

Powered by Google App Engine
This is Rietveld 408576698