Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated mpearson@'s comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
index 6faa08e31304b61f046b2286e020d3f1f6afb9cc..ef9fd4ed8d2029cc8e2b83e89f49cbace2fc0a3c 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
@@ -161,6 +161,11 @@ void RespondWithObserver::contextDestroyed()
m_state = Done;
}
+void RespondWithObserver::willDispatchEvent()
+{
+ m_eventDispatchTime = WTF::currentTime();
+}
+
void RespondWithObserver::didDispatchEvent(DispatchEventResult dispatchResult)
{
ASSERT(getExecutionContext());
@@ -173,7 +178,7 @@ void RespondWithObserver::didDispatchEvent(DispatchEventResult dispatchResult)
return;
}
- ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID);
+ ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID, m_eventDispatchTime);
m_state = Done;
m_observer.clear();
}
@@ -201,7 +206,7 @@ void RespondWithObserver::responseWasRejected(WebServiceWorkerResponseError erro
// to a network error.
WebServiceWorkerResponse webResponse;
webResponse.setError(error);
- ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID, webResponse);
+ ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID, webResponse, m_eventDispatchTime);
m_state = Done;
m_observer->decrementPendingActivity();
m_observer.clear();
@@ -267,7 +272,7 @@ void RespondWithObserver::responseWasFulfilled(const ScriptValue& value)
buffer->startLoading(FetchDataLoader::createLoaderAsStream(outStream), new NoopLoaderClient);
}
}
- ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID, webResponse);
+ ServiceWorkerGlobalScopeClient::from(getExecutionContext())->respondToFetchEvent(m_eventID, webResponse, m_eventDispatchTime);
m_state = Done;
m_observer->decrementPendingActivity();
m_observer.clear();

Powered by Google App Engine
This is Rietveld 408576698