Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated mpearson@'s comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index a009d30c4920bee905cab895320cac27fd6d9a8a..3806ef8644b3308ffea21ec65fb2e2f164bae929 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -65,7 +65,8 @@ class ServiceWorkerContextClient
: public blink::WebServiceWorkerContextClient {
public:
using SyncCallback =
- base::Callback<void(blink::mojom::ServiceWorkerEventStatus)>;
+ base::Callback<void(blink::mojom::ServiceWorkerEventStatus,
+ double /* dispatch_event_time */)>;
// Returns a thread-specific client instance. This does NOT create a
// new instance.
@@ -129,29 +130,37 @@ class ServiceWorkerContextClient
blink::WebDevToolsAgentClient::WebKitClientMessageLoop*
createDevToolsMessageLoop() override;
void didHandleActivateEvent(int request_id,
- blink::WebServiceWorkerEventResult) override;
+ blink::WebServiceWorkerEventResult,
+ double dispatch_event_time) override;
void didHandleExtendableMessageEvent(
int request_id,
- blink::WebServiceWorkerEventResult result) override;
- void didHandleInstallEvent(
- int request_id,
- blink::WebServiceWorkerEventResult result) override;
- void respondToFetchEvent(int response_id) override;
- void respondToFetchEvent(
- int response_id,
- const blink::WebServiceWorkerResponse& response) override;
+ blink::WebServiceWorkerEventResult result,
+ double dispatch_event_time) override;
+ void didHandleInstallEvent(int request_id,
+ blink::WebServiceWorkerEventResult result,
+ double event_dispatch_time) override;
+ void respondToFetchEvent(int response_id,
+ double event_dispatch_time) override;
+ void respondToFetchEvent(int response_id,
+ const blink::WebServiceWorkerResponse& response,
+ double event_dispatch_time) override;
void didHandleFetchEvent(int event_finish_id,
- blink::WebServiceWorkerEventResult result) override;
+ blink::WebServiceWorkerEventResult result,
+ double dispatch_event_time) override;
void didHandleNotificationClickEvent(
int request_id,
- blink::WebServiceWorkerEventResult result) override;
+ blink::WebServiceWorkerEventResult result,
+ double dispatch_event_time) override;
void didHandleNotificationCloseEvent(
int request_id,
- blink::WebServiceWorkerEventResult result) override;
+ blink::WebServiceWorkerEventResult result,
+ double dispatch_event_time) override;
void didHandlePushEvent(int request_id,
- blink::WebServiceWorkerEventResult result) override;
+ blink::WebServiceWorkerEventResult result,
+ double dispatch_event_time) override;
void didHandleSyncEvent(int request_id,
- blink::WebServiceWorkerEventResult result) override;
+ blink::WebServiceWorkerEventResult result,
+ double dispatch_event_time) override;
// Called on the main thread.
blink::WebServiceWorkerNetworkProvider* createServiceWorkerNetworkProvider(

Powered by Google App Engine
This is Rietveld 408576698