Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2041)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated mpearson@'s comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 23455e6171ccec1fd1999833721b03feb5892901..087ebe5ba0918e7c09be1a5ffeea2e956a7809c3 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -26,6 +26,7 @@
#include "base/observer_list.h"
#include "base/optional.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
#include "base/timer/timer.h"
#include "content/browser/service_worker/embedded_worker_instance.h"
#include "content/browser/service_worker/embedded_worker_status.h"
@@ -239,7 +240,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
// Pass the result of the event to |was_handled|, which is used to record
// statistics based on the event status.
// TODO(mek): Use something other than a bool for event status.
- bool FinishRequest(int request_id, bool was_handled);
+ bool FinishRequest(int request_id,
+ bool was_handled,
+ base::Time dispatch_event_time);
// Connects to a specific mojo service exposed by the (running) service
// worker. If a connection to a service for the same Interface already exists
@@ -425,7 +428,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
struct PendingRequest {
PendingRequest(const StatusCallback& error_callback,
- const base::TimeTicks& time,
+ base::Time time,
+ const base::TimeTicks& time_ticks,
ServiceWorkerMetrics::EventType event_type);
~PendingRequest();
@@ -433,7 +437,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
// For all requests. Set by StartRequest.
// ------------------------------------------------------------------------
StatusCallback error_callback;
- base::TimeTicks start_time;
+ base::Time start_time;
+ base::TimeTicks start_time_ticks;
ServiceWorkerMetrics::EventType event_type;
// -------------------------------------------------------------------------
@@ -572,7 +577,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
const ServiceWorkerClientQueryOptions& options);
void OnSimpleEventResponse(int request_id,
- blink::WebServiceWorkerEventResult result);
+ blink::WebServiceWorkerEventResult result,
+ base::Time dispatch_event_time);
void OnOpenWindow(int request_id, GURL url);
void OnOpenWindowFinished(int request_id,
ServiceWorkerStatusCode status,

Powered by Google App Engine
This is Rietveld 408576698