Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1401)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated mpearson@'s comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index bdefff4ba6194f6735daf324821bba8bce4c6956..2b05b9bb1c2c16538663d8c6c4a805a6ca229b21 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -12,6 +12,7 @@
#include "base/bind.h"
#include "base/memory/scoped_vector.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "base/time/time.h"
#include "content/browser/message_port_message_filter.h"
#include "content/browser/service_worker/embedded_worker_instance.h"
#include "content/browser/service_worker/embedded_worker_registry.h"
@@ -212,14 +213,14 @@ void EmbeddedWorkerTestHelper::OnActivateEvent(int embedded_worker_id,
int request_id) {
SimulateSend(new ServiceWorkerHostMsg_ActivateEventFinished(
embedded_worker_id, request_id,
- blink::WebServiceWorkerEventResultCompleted));
+ blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
}
void EmbeddedWorkerTestHelper::OnExtendableMessageEvent(int embedded_worker_id,
int request_id) {
SimulateSend(new ServiceWorkerHostMsg_ExtendableMessageEventFinished(
embedded_worker_id, request_id,
- blink::WebServiceWorkerEventResultCompleted));
+ blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
}
void EmbeddedWorkerTestHelper::OnInstallEvent(int embedded_worker_id,
@@ -229,7 +230,7 @@ void EmbeddedWorkerTestHelper::OnInstallEvent(int embedded_worker_id,
return;
SimulateSend(new ServiceWorkerHostMsg_InstallEventFinished(
embedded_worker_id, request_id,
- blink::WebServiceWorkerEventResultCompleted, true));
+ blink::WebServiceWorkerEventResultCompleted, true, base::Time::Now()));
}
void EmbeddedWorkerTestHelper::OnFetchEvent(
@@ -246,10 +247,11 @@ void EmbeddedWorkerTestHelper::OnFetchEvent(
blink::WebServiceWorkerResponseErrorUnknown, base::Time(),
false /* is_in_cache_storage */,
std::string() /* cache_storage_cache_name */,
- ServiceWorkerHeaderList() /* cors_exposed_header_names */)));
+ ServiceWorkerHeaderList() /* cors_exposed_header_names */),
+ base::Time::Now()));
SimulateSend(new ServiceWorkerHostMsg_FetchEventFinished(
embedded_worker_id, event_finish_id,
- blink::WebServiceWorkerEventResultCompleted));
+ blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
}
void EmbeddedWorkerTestHelper::OnPushEvent(int embedded_worker_id,
@@ -257,7 +259,7 @@ void EmbeddedWorkerTestHelper::OnPushEvent(int embedded_worker_id,
const PushEventPayload& payload) {
SimulateSend(new ServiceWorkerHostMsg_PushEventFinished(
embedded_worker_id, request_id,
- blink::WebServiceWorkerEventResultCompleted));
+ blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
}
void EmbeddedWorkerTestHelper::SimulateWorkerReadyForInspection(

Powered by Google App Engine
This is Rietveld 408576698