Introduce ServiceWorker.EventDispatchingDelay UMA

third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom

Index: third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom
diff --git a/third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom b/third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom
index 15c1c59a9b6980f46fdb0eafb737aec552135727..1002925f7cda504f9fc577c0f53dc32ecc5eb610 100644
--- a/third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom
+++ b/third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom
@@ -49,5 +49,5 @@ interface BackgroundSyncService {
 
 interface BackgroundSyncServiceClient {
   Sync(string tag, BackgroundSyncEventLastChance last_chance)
-      => (ServiceWorkerEventStatus status);
+      => (ServiceWorkerEventStatus status, double dispatch_event_time);

[dcheng, 2016/08/23 05:37:21]

Is it possible to use the mojom type for this? See
https://cs.chromium.org/chromium/src/mojo/common/common_custom_types.mojom: I'm
not sure if Blink can depend on this, but it would be nice.

[horo, 2016/08/23 07:01:58]

Sorry, I don't understand mojo well.
When I changed this "double" to "mojo.common.mojom.Time", this
BackgroundSyncServiceClient is generated in background_sync.mojom.h.


class CONTENT_EXPORT BackgroundSyncServiceClient {
 public:
  static const char Name_[];
  static const uint32_t Version_ = 0;
  static const bool PassesAssociatedKinds_ = false;
  static const bool HasSyncMethods_ = false;

  using Proxy_ = BackgroundSyncServiceClientProxy;
  using Stub_ = BackgroundSyncServiceClientStub;

  using RequestValidator_ = BackgroundSyncServiceClientRequestValidator;
  using ResponseValidator_ = BackgroundSyncServiceClientResponseValidator;
  virtual ~BackgroundSyncServiceClient() {}


  using SyncCallback =
base::Callback<void(::blink::mojom::ServiceWorkerEventStatus,
::mojo::common::mojom::TimePtr)>;
  virtual void Sync(const mojo::String& tag, BackgroundSyncEventLastChance
last_chance, const SyncCallback& callback) = 0;
};

Could you please let me know how to pass base::Time to SyncCallback?

[Marijn Kruisselbrink, 2016/08/23 19:04:30]

You'd probably add a //src/mojo/common/blink_typemaps.gni file, to which you'd
link from //src/mojo/public/tools/bindings/blink_bindings_configuration.gni.
That blink_typemaps.gni file would then be similar to the existing
//src/mojo/common/typemaps.gni file, but instead link to a blink specific
//src/mojo/common/blink_common_custom_types.typemap file, which again would be
similar to the existing common_custom_types.typemap file. Not sure which of the
common types would actually be allowed in blink though, and what the correct
contents of that new typemap file would be (if all of it should be okay,
blink_bindings_configuration.gni can maybe just link directly to the existing
typemaps.gni file, making this all a lot simpler).

 };