content/renderer/service_worker/service_worker_context_client.h - Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/2249063004/#ps40001 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index a009d30c4920bee905cab895320cac27fd6d9a8a..41065665fffc20f21dc227d5c5b322932c8dc747 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -136,10 +136,11 @@ class ServiceWorkerContextClient

void didHandleInstallEvent(

int request_id,

blink::WebServiceWorkerEventResult result) override;

- void respondToFetchEvent(int response_id) override;

- void respondToFetchEvent(

- int response_id,

- const blink::WebServiceWorkerResponse& response) override;

+ void respondToFetchEvent(int response_id,

+ double event_dispatch_time) override;

+ void respondToFetchEvent(int response_id,

+ const blink::WebServiceWorkerResponse& response,

+ double event_dispatch_time) override;

void didHandleFetchEvent(int event_finish_id,

blink::WebServiceWorkerEventResult result) override;

void didHandleNotificationClickEvent(