content/browser/service_worker/service_worker_dispatcher_host_unittest.cc - Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/2249063004/#ps40001 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_test_helper.cc ('k') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('j') | content/browser/service_worker/service_worker_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

index 1113d8b18fb9c5de32c767e28c392badde434697..6befde019d33705b1b3ff6cbd4cdfbc936f71fb4 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc

@@ -12,6 +12,7 @@

#include "base/files/file_path.h"

#include "base/memory/ptr_util.h"

#include "base/run_loop.h"

+#include "base/time/time.h"

#include "content/browser/browser_thread_impl.h"

#include "content/browser/message_port_service.h"

#include "content/browser/service_worker/embedded_worker_instance.h"

@@ -825,7 +826,8 @@ TEST_F(ServiceWorkerDispatcherHostTest, ReceivedTimedOutRequestResponse) {

const int kRequestId = 91; // Dummy value

dispatcher_host_->OnMessageReceived(ServiceWorkerHostMsg_FetchEventResponse(

version_->embedded_worker()->embedded_worker_id(), kRequestId,

- SERVICE_WORKER_FETCH_EVENT_RESULT_FALLBACK, ServiceWorkerResponse()));

+ SERVICE_WORKER_FETCH_EVENT_RESULT_FALLBACK, ServiceWorkerResponse(),

+ base::Time::Now()));

base::RunLoop().RunUntilIdle();

EXPECT_EQ(0, dispatcher_host_->bad_messages_received_count_);