third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom - Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA

Side by Side Diff: third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: EventDispatchingDelay Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module blink.mojom;	5 module blink.mojom;

6	6

7 import "third_party/WebKit/public/platform/modules/serviceworker/service_worker_ event_status.mojom";	7 import "third_party/WebKit/public/platform/modules/serviceworker/service_worker_ event_status.mojom";

8	8

9 enum BackgroundSyncNetworkState {	9 enum BackgroundSyncNetworkState {

10 ANY,	10 ANY,

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42	42

43 interface BackgroundSyncService {	43 interface BackgroundSyncService {

44 Register(SyncRegistration options, int64 service_worker_registration_id)	44 Register(SyncRegistration options, int64 service_worker_registration_id)

45 => (BackgroundSyncError err, SyncRegistration options);	45 => (BackgroundSyncError err, SyncRegistration options);

46 GetRegistrations(int64 service_worker_registration_id)	46 GetRegistrations(int64 service_worker_registration_id)

47 => (BackgroundSyncError err, array<SyncRegistration> registrations);	47 => (BackgroundSyncError err, array<SyncRegistration> registrations);

48 };	48 };

49	49

50 interface BackgroundSyncServiceClient {	50 interface BackgroundSyncServiceClient {

51 Sync(string tag, BackgroundSyncEventLastChance last_chance)	51 Sync(string tag, BackgroundSyncEventLastChance last_chance)

52 => (ServiceWorkerEventStatus status);	52 => (ServiceWorkerEventStatus status, double dispatch_event_time);
	dcheng 2016/08/23 05:37:21 Is it possible to use the mojom type for this? See Is it possible to use the mojom type for this? See https://cs.chromium.org/chromium/src/mojo/common/common_custom_types.mojom: I'm not sure if Blink can depend on this, but it would be nice. horo 2016/08/23 07:01:58 Sorry, I don't understand mojo well. When I change Show quoted text On 2016/08/23 05:37:21, dcheng wrote: > Is it possible to use the mojom type for this? See > https://cs.chromium.org/chromium/src/mojo/common/common_custom_types.mojom: I'm > not sure if Blink can depend on this, but it would be nice. Sorry, I don't understand mojo well. When I changed this "double" to "mojo.common.mojom.Time", this BackgroundSyncServiceClient is generated in background_sync.mojom.h. class CONTENT_EXPORT BackgroundSyncServiceClient { public: static const char Name_[]; static const uint32_t Version_ = 0; static const bool PassesAssociatedKinds_ = false; static const bool HasSyncMethods_ = false; using Proxy_ = BackgroundSyncServiceClientProxy; using Stub_ = BackgroundSyncServiceClientStub; using RequestValidator_ = BackgroundSyncServiceClientRequestValidator; using ResponseValidator_ = BackgroundSyncServiceClientResponseValidator; virtual ~BackgroundSyncServiceClient() {} using SyncCallback = base::Callback<void(::blink::mojom::ServiceWorkerEventStatus, ::mojo::common::mojom::TimePtr)>; virtual void Sync(const mojo::String& tag, BackgroundSyncEventLastChance last_chance, const SyncCallback& callback) = 0; }; Could you please let me know how to pass base::Time to SyncCallback? Marijn Kruisselbrink 2016/08/23 19:04:30 You'd probably add a //src/mojo/common/blink_typem Show quoted text On 2016/08/23 at 07:01:58, horo wrote: > On 2016/08/23 05:37:21, dcheng wrote: > > Is it possible to use the mojom type for this? See > > https://cs.chromium.org/chromium/src/mojo/common/common_custom_types.mojom: I'm > > not sure if Blink can depend on this, but it would be nice. > > > Sorry, I don't understand mojo well. > When I changed this "double" to "mojo.common.mojom.Time", this BackgroundSyncServiceClient is generated in background_sync.mojom.h. > > > class CONTENT_EXPORT BackgroundSyncServiceClient { > public: > static const char Name_[]; > static const uint32_t Version_ = 0; > static const bool PassesAssociatedKinds_ = false; > static const bool HasSyncMethods_ = false; > > using Proxy_ = BackgroundSyncServiceClientProxy; > using Stub_ = BackgroundSyncServiceClientStub; > > using RequestValidator_ = BackgroundSyncServiceClientRequestValidator; > using ResponseValidator_ = BackgroundSyncServiceClientResponseValidator; > virtual ~BackgroundSyncServiceClient() {} > > > using SyncCallback = base::Callback<void(::blink::mojom::ServiceWorkerEventStatus, ::mojo::common::mojom::TimePtr)>; > virtual void Sync(const mojo::String& tag, BackgroundSyncEventLastChance last_chance, const SyncCallback& callback) = 0; > }; > > Could you please let me know how to pass base::Time to SyncCallback? You'd probably add a //src/mojo/common/blink_typemaps.gni file, to which you'd link from //src/mojo/public/tools/bindings/blink_bindings_configuration.gni. That blink_typemaps.gni file would then be similar to the existing //src/mojo/common/typemaps.gni file, but instead link to a blink specific //src/mojo/common/blink_common_custom_types.typemap file, which again would be similar to the existing common_custom_types.typemap file. Not sure which of the common types would actually be allowed in blink though, and what the correct contents of that new typemap file would be (if all of it should be okay, blink_bindings_configuration.gni can maybe just link directly to the existing typemaps.gni file, making this all a lot simpler).
53 };	53 };

OLD	NEW