Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2218933003: Revert of Make WebTraceLocation be an alias of tracked_objects::Location (Closed)

Created:
4 years, 4 months ago by nednguyen
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make WebTraceLocation be an alias of tracked_objects::Location (patchset #6 id:100001 of https://codereview.chromium.org/2137013002/ ) Reason for revert: Speculative revert: this CL may regress system_health.memory_mobile benchmark BUG=629112 Original issue's description: > Make WebTraceLocation be an alias of tracked_objects::Location > > Make WebTraceLocation be an alias of tracked_objects::Location and > BLINK_FROM_HERE be an alias of FROM_HERE as well. So that tasks posted > from Blink leaves a valid program counter and line number in the crash > dump. > > Committed: https://crrev.com/3c109dd65c1984237444da93f7c7acc8b0bdcd92 > Cr-Commit-Position: refs/heads/master@{#405736} TBR=esprehn@chromium.org,alexclarke@chromium.org,kinuko@chromium.org,tkent@chromium.org,tzik@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -44 lines) Patch
M components/scheduler/child/web_scheduler_impl.cc View 2 chunks +15 lines, -10 lines 0 comments Download
M components/scheduler/child/web_task_runner_impl.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M components/scheduler/child/webthread_base.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/scheduler/child/webthread_base.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_scheduling_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebTraceLocation.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/threading/BackgroundTaskRunner.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebScheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebThread.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebTraceLocation.h View 1 chunk +18 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
Created Revert of Make WebTraceLocation be an alias of tracked_objects::Location
4 years, 4 months ago (2016-08-05 20:03:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218933003/1
4 years, 4 months ago (2016-08-05 20:04:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/272678)
4 years, 4 months ago (2016-08-05 20:06:37 UTC) #5
esprehn
4 years, 4 months ago (2016-08-05 20:52:29 UTC) #6
This patch is so old, I suspect you'd need to manually revert.

Powered by Google App Engine
This is Rietveld 408576698